820157 - bluetooth Hfp not sending status updates

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Greg Grisco]

Checked using Mecapp and NOKIA 616 Carkit.  Changes in the following status are not being sent to HF:

1. Transfer of Registration Status
2. Transfer of Signal Strength Indication
3. Transfer of Roaming Status Indication
4. Transfer of Battery Level Indication
5. SMS indication

Comment 1

[Chris Lee [:clee]]

We're confirming with others on the team, but car/auto support is likely not a requirement for v1.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Synced with product team. We need more time to figure out if Bluetooth module would be able to be notified of these status changes.

Comment 3

[Chris Lee [:clee]]

Eric is on this and will follow-up on the feasibility here.

Eric, can you confirm if this is necessary for any type of certification?

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Update registration status, signal strength, roaming status

When mobile voice connection info is updated, we'll check registration status, signal strength and roaming status, and transfer them to HS if they're updated.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 692240 [details] [diff] [review]
Patch 1(v1): Update registration status, signal strength, roaming status

Review of attachment 692240 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me with nits addressed.

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +29,4 @@
>  #define AUDIO_VOLUME_BT_SCO "audio.volume.bt_sco"
> +#define MOZSETTINGS_CHANGED_ID "mozsettings-changed"
> +#define MOBILE_CONNECTION_VOICE_CHANGED "mobile-connection-voice-changed"
> +#define NS_RILCONTENTHELPER_CONTRACTID "@mozilla.org/ril/content-helper;1"

This has been defined in nsRadioInterfaceLayer.h, just include and use it.

@@ +756,5 @@
>  bool
>  BluetoothHfpManager::SendCommand(const char* aCommand, const int aValue)
>  {
> +  if (mSocketStatus == SocketConnectionStatus::SOCKET_DISCONNECTED ||
> +      mSocketStatus == SocketConnectionStatus::SOCKET_LISTENING) {

"if (mSocketStatus != SocketConnectionStatus::SOCKET_CONNECTED)" would be fine, I think.

Comment 6

[Eric Chou [:ericchou] [:echou]]

(In reply to Chris Lee [:clee] from comment #3)
> Eric is on this and will follow-up on the feasibility here.
> 
> Eric, can you confirm if this is necessary for any type of certification?

1. Transfer of Registration Status
2. Transfer of Signal Strength Indication
3. Transfer of Roaming Status Indication
4. Transfer of Battery Level Indication
5. SMS indication

The patch solved point 1~3, but we won't fix 4 and 5 by v1 because we are unable to get the status update of Battery and SMS. I think this won't affect the result of conformance test.

Comment 7

[Dietrich Ayala (:dietrich)]

Thanks Eric. Can you file a followup bug for 4 & 5, and we'll target that for a subsequent release.

Comment 8

[Eric Chou [:ericchou] [:echou]]

(In reply to Dietrich Ayala (:dietrich) from comment #7)
> Thanks Eric. Can you file a followup bug for 4 & 5, and we'll target that
> for a subsequent release.

I filed a follow-up for 4 (bug 823346). However, for the implementation of SMS indication, it is included in another profile - MAP (Message Access Profile), so I would prefer not filing a bug for now since we haven't had a schedule for MAP.

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1:bluetooth Hfp not sending status updates, r=echou

try:
https://tbpl.mozilla.org/?tree=Try&rev=1ae90445bb42
https://tbpl.mozilla.org/?tree=Try&rev=f8ebc975500e

Comment 10

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebad7aef8c52

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ebad7aef8c52

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/155651658843
https://hg.mozilla.org/releases/mozilla-b2g18/rev/f20928b629a9