bluetooth doesn't stop searching for other devices

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

Firefox OS
Gaia::Settings
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Greg Grisco, Assigned: evelyn)

Tracking

unspecified
B2G C3 (12dec-1jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: [target:12/21])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Go to Settings>Bluetooth.
Here we observe that the device keeps inquiring for nearby devices. After Inquiry completes, again Inquiry command is sent, and thus the device keeps Inquiring.
Even when HOME key is pressed, and when power key is pressed (so that the device goes into suspend mode), the Inquiry doesn't stop.
(Reporter)

Updated

5 years ago
Depends on: 802677
Blocks: 802677
No longer depends on: 802677

Updated

5 years ago
QA Contact: wachen
The state of discovering could be controlled by applications via calling StartDiscovery()/StopDiscovery(). I don't remember that I've ever seen this requirement or scenario defined in UX spec, especially in the case that HOME/POWER key is pressed. The latest UX spec I can find is v11: 

https://www.dropbox.com/sh/ygwfxk6chpshxdj/gclt7lI4JJ/Apps/Settings/R1_Connectivity_v11.pdf

Discovering is a heavy loading procedure. In my opinion, we should let it timed out with a period of time, like 60 or 90 seconds, and enable "Search again" button after discovering is stopped.

+needinfo Larissa, We need advice from our UX designer of Settings.
Flags: needinfo?(lco)
Triage: Blocking on certification problem potential
blocking-basecamp: ? → +
Priority: -- → P1
Assignee: nobody → echou
Target Milestone: --- → B2G C3 (12dec-1jan)

Comment 3

5 years ago
Yes, let's have it timeout after 90 seconds while the user is on the bluetooth settings page. It should automatically timeout too when the user exits the bluetooth settings page.
Flags: needinfo?(lco)
Whiteboard: [target:12/21]
Eric, what's your estimate for fixing this?
(In reply to Dietrich Ayala (:dietrich) from comment #4)
> Eric, what's your estimate for fixing this?

It would be done in Gaia, so I'll let Evelyn to estimate.

The modifications would be:

 (1) shorten the period of discovering time to a more reasonable value (90 secs).
 (2) timeout and stop discovering whenever leaving Bluetooth(in Settings) page.

If you have any questions, please let me know.
Thank you.

Eric
Assignee: echou → ehung
(Assignee)

Comment 6

5 years ago
I'm doing now. Hope I can submit my patch today.
(Assignee)

Comment 7

5 years ago
Created attachment 691285 [details]
point to https://github.com/mozilla-b2g/gaia/pull/6969

In this patch, I didn't update discovering time, because it's 60 seconds now, it's short enough.
I stop discovering nearby devices when Settings app is pushed to the background.
Also do some code clean up and error checking.
Attachment #691285 - Flags: review?(timdream+bugs)
Comment on attachment 691285 [details]
point to https://github.com/mozilla-b2g/gaia/pull/6969

r=me, after fixing stopDiscovery() and manual tests.
Attachment #691285 - Flags: review?(timdream+bugs) → review+
(Assignee)

Comment 9

5 years ago
Move mozHidden checking out of stopDiscovery() function, create another function for checking instead. Tested and it works.

Eric will help on creating a follow-up issue for the problem that Bluetooth defaultAdapter.stopDiscovery() DOM request sometimes won't return back.

Commit merged:
https://github.com/mozilla-b2g/gaia/commit/ba1f14083f36500cd49397d83e8ddd111684764a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Fixed in https://releases.mozilla.com/b2g/ 20121212 build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.