82022 - xml-stylesheet without href in XUL document gives blank page

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I fixed this in normal XML, we treated empty href and !href differently,
returning error code if !href, which stopped parsing. I suspect this is also a
one line fix.

This grew out from bug 71151. I'll attach a testcase that was there, no idea if
it is correct XUL.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: testcase

Comment 2

[basic]

note that Heikki's fix for xml was in bug 73160

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to me, I found were the bug is...

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I have the fix in my tree, will attach... The problem was
nsParserUtils::GetQuotedAttributeValue() which returns NS_ERROR_FAILURE if the
attribute is not present, and we propagated that value out which stopped layout.
Ignoring the return value fixes this. There is a bug on harishd's plate on
fixing the wrong return values from nsParserUtils::GetQuotedAttributeValue()
(bug 77791).

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Fix: ignore buggy return values

Comment 6

[harishd]

Please double check this part

+        nsresult rv = NS_NewURI(getter_AddRefs(url), href, mDocumentURL);
         if (NS_FAILED(rv)) {
             return NS_OK; // The URL is bad, move along. Don't propogate for now.
         }

Shouldn't we return NS_ERROR_OUT_OF_MEMORY atleast?

Other than that r=harishd

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

The error returns are a can of worms. NS_NewURI can return out of memory, but
NS_ERROR_MALFORMED_URI is also an error code, as are several other non-critical
conditions in necko. Some error codes should really be changed into
success-with-info codes.

We discussed this with harishd, and decided to add a comment about that to the
code, but leave it otherwise as is.

Comment 8

[vidur (gone)]

sr=vidur

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Fixed.

Comment 10

[Chad Austin]

verified win2k (my trunk pull from yesterday)
         linux 2001072606