820263 - Use platform's line breaker for Khmer language

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Makoto Kato [:m_kato]]

Thai, Lao and Tibetan uses Platform's line breaker (Uniscriber, Carbon and Pango).  We should use it for Kmer too.

Comment 1

[Makoto Kato [:m_kato]]

s/Kmer/Khmer/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 694730 [details] [diff] [review]
fix

Aren't we going to use ICU line breaker?

>diff --git a/intl/lwbrk/src/jisx4501class.h b/intl/lwbrk/src/jisx4501class.h
>--- a/intl/lwbrk/src/jisx4501class.h
>+++ b/intl/lwbrk/src/jisx4501class.h

Let's fix the filename typo while you are here. Unlike the CVS era, rename is very easy.

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> Comment on attachment 694730 [details] [diff] [review]
> fix
> 
> Aren't we going to use ICU line breaker?

If ICU is into m-c, I want to replace with it.  (bug 820261).  But many developers are negative to land ICU into m-c. (https://groups.google.com/forum/?fromgroups=#!searchin/mozilla.dev.platform/icu/mozilla.dev.platform/sVVpS2sKODw/6EgTE2-QeW4J)

But B2G has ICU, so we can use it as complex script on B2G.  (Also, android has ICU, but version suffix is added for all functions due to android's ICU build configuration.  So we cannot use it even if dynamic loading)

> Let's fix the filename typo while you are here. Unlike the CVS era, rename is very easy.

It should be filed as another bug.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: fix

2 issues.

- khmer should mark as COMPLEX.
- U+17D8 (KHMER SIGN BEYYAL) and U+17DA (KHMER SIGN KOOMUUT) are visible word dividers.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 719825 [details] [diff] [review]
fix

Hmm, then, U+1735 (PHILIPPINE SINGLE PUNCTUATION) and U+1736 (PHILIPPINE DOUBLE PUNCTUATION) should be defined as "1" too. But if you want to separate this issue to another bug, it's okay. If you agree with this, please fix them. Either is okay.

Comment 7

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb1497be5dbb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb1497be5dbb