820458 - DOMWifiManager.js" line: 137 Assertion

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

I see this at startup on a otoro device running a build from today.  Not sure if it is important or not.

I/Gecko   (  106): WARNING: NS_ENSURE_TRUE(aRequest) failed: file /builds/mozilla-central/dom/base/DOMRequest.cpp, line 220
E/GeckoConsole(  106): [JavaScript Error: "NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIDOMRequestService.fireError]" {file: "jar:file:///system/b2g/omni.ja!/components/DOMWifiManager.js" line: 137}]

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 820458 - Try harder to avoid notifying for the same request twice.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 694391 [details] [diff] [review]
Bug 820458 - Try harder to avoid notifying for the same request twice.

This is pretty self-explanatory. Basically, there could have already been a request to scan when we ask to scan, causing us to receive scan results but have the original request to scan fail.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 694391 [details] [diff] [review]
Bug 820458 - Try harder to avoid notifying for the same request twice.

Review of attachment 694391 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is really cool.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44e32ae854d8

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 694391 [details] [diff] [review]
Bug 820458 - Try harder to avoid notifying for the same request twice.

[Approval Request Comment]
User impact if declined: The API will behave oddly in certain cases.
Testing completed: I've had this in my tree for a while. It's now on inbound.
Risk to taking this patch (and alternatives if risky): Little to no risk.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/44814eb603cc

Comment 7

[Johnny Stenback (:jst)]

Marking FIXED as this is already on inbound and b2g18 (per b2g endgame rule).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/44e32ae854d8