820463 - Revert the early loading code

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

We should back out the early loading code landed as part of the work on bug 800138, since it turns out to be unnecessary.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Revert early-loading changes,

This patch works on the panda, need to test on unagi and through try still.

Comment 2

[Jonathan Griffin (:jgriffin)]

pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=8be1cb2f5420

Comment 3

[Mozilla RelEng Bot]

Try run for 8be1cb2f5420 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8be1cb2f5420
Results (out of 19 total builds):
    success: 18
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-8be1cb2f5420

Comment 4

[Mozilla RelEng Bot]

Try run for 8be1cb2f5420 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8be1cb2f5420
Results (out of 20 total builds):
    success: 19
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-8be1cb2f5420

Comment 5

[Jonathan Griffin (:jgriffin)]

Attachment: Revert early-loading changes,

Patch passes try and works fine locally on unagi and panda

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 693175 [details] [diff] [review]
Revert early-loading changes,

Review of attachment 693175 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, are there any profiles in gaia or b2g repos where they reference this preference and if so are they removed as well?

Comment 7

[Jonathan Griffin (:jgriffin)]

(In reply to Malini Das [:mdas] from comment #6)
> Comment on attachment 693175 [details] [diff] [review]
> Revert early-loading changes,
> 
> Review of attachment 693175 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgtm, are there any profiles in gaia or b2g repos where they reference this
> preference and if so are they removed as well?

There aren't AFAIK. 

After this lands, there will still be two things left to do:

- update the mozharness scripts not to pass --load-early any longer
- remove the --load-early CLI from Marionette

Comment 8

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22f9cf3cc575

Comment 9

[Ed Morley [:emorley]]

Backed out for marionette failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=22f9cf3cc575&jobname=marionette

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0a563745fb6

Comment 10

[Jonathan Griffin (:jgriffin)]

Attachment: try: -b o -p ics_armv7a_gecko -t none -u all --post-to-bugzilla

Fixed problem with desktop Marionette; pushed to try for desktop (https://tbpl.mozilla.org/?tree=Try&rev=7b72639a2ee3) and B2G (https://tbpl.mozilla.org/?tree=Try&rev=6ac23e581f0e)

Comment 11

[Jonathan Griffin (:jgriffin)]

Attachment: Revert early-loading changes,

Fixed problem with desktop Marionette; pushed to try for desktop (https://tbpl.mozilla.org/?tree=Try&rev=7b72639a2ee3) and B2G (https://tbpl.mozilla.org/?tree=Try&rev=6ac23e581f0e)

Comment 12

[Jonathan Griffin (:jgriffin)]

Comment on attachment 697188 [details] [diff] [review]
Revert early-loading changes,

Carry r+ forward.

Comment 13

[Jonathan Griffin (:jgriffin)]

Another try push for B2G, the last one only got the empty try commit...

https://tbpl.mozilla.org/?tree=Try&rev=850ecef2f239

Comment 14

[Mozilla RelEng Bot]

Try run for 7b72639a2ee3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7b72639a2ee3
Results (out of 4 total builds):
    success: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7b72639a2ee3

Comment 15

[Jonathan Griffin (:jgriffin)]

Try runs all green this time!

https://hg.mozilla.org/integration/mozilla-inbound/rev/53e402890d35

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/53e402890d35

Comment 17

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/b2f781164204

Comment 18

[Jonathan Griffin (:jgriffin)]

Attachment: Remove loadearly code from test runners,

The previous patch made the pref marionette.loadearly do nothing; this patch removes all traces of loadearly from the testrunners, except for the Marionette CLI which is being used by mozharness.  After this lands, we can patch the mozharness scripts, then remove the CLI as well.

Comment 19

[Jonathan Griffin (:jgriffin)]

(In reply to Jonathan Griffin (:jgriffin) from comment #18)
> Created attachment 703500 [details] [diff] [review]
> Remove loadearly code from test runners,
> 
> The previous patch made the pref marionette.loadearly do nothing; this patch
> removes all traces of loadearly from the testrunners, except for the
> Marionette CLI which is being used by mozharness.  After this lands, we can
> patch the mozharness scripts, then remove the CLI as well.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=07b6f57c7076

Comment 20

[Andrew Halberstadt [:ahal]]

Comment on attachment 703500 [details] [diff] [review]
Remove loadearly code from test runners,

Review of attachment 703500 [details] [diff] [review]:
-----------------------------------------------------------------

Nuke it!

Comment 21

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cde7a236b28d
https://hg.mozilla.org/releases/mozilla-b2g18/rev/2d26e984f63e

Comment 22

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/cde7a236b28d

Comment 23

[Michael Vines [:m1] [:evilmachines]]

Why did this land on b2g18 without tef+?   This breaks us it seems :(

Comment 24

[Michael Vines [:m1] [:evilmachines]]

Opps.  My bad, wrong bug. This doesn't break us!

But my question about why this landed on b2g18 without tef+ stands.

Comment 25

[Jonathan Griffin (:jgriffin)]

(In reply to Michael Vines [:m1] from comment #24)
> Opps.  My bad, wrong bug. This doesn't break us!
> 
> But my question about why this landed on b2g18 without tef+ stands.

Sorry, it wasn't totally clear that the tef+ requirement applied to test-only bugs.  Should we refrain from landing any automation changes on b2g18 without tef+?

Comment 26

[Michael Vines [:m1] [:evilmachines]]

That would be my preference at this point yes.  Any automation changes, even though test-only, could affect our automation as well and unexpected automation bustage generally causes unnecessary hardship during crunch time.

Comment 27

[Jonathan Griffin (:jgriffin)]

Attachment: Bugggg - Remove --load-earlyargument from Marionette script,

The next step is to remove the --load-early command-line arg from the mozharness Marionette script, since it currently does nothing.  I'll test this on ash.

Comment 28

[Jonathan Griffin (:jgriffin)]

Finally landed the mozharness change:  http://hg.mozilla.org/build/mozharness/rev/24c361d3fc70

I'll watch the trees for bustage.   After this sticks, there's one more trivial gecko change that needs to land.

Comment 29

[Jonathan Griffin (:jgriffin)]

Attachment: Remove the --load-early CLI,

This just removes the now-unused --load-early command-line arg from Marionette.

Comment 30

[Jonathan Griffin (:jgriffin)]

The last piece of this!

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b7bf70c3be2

Comment 31

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b7bf70c3be2

Comment 32

[Malini Das [:mdas] - Away, not checking bugmail]

https://hg.mozilla.org/releases/mozilla-b2g18/pushloghtml?changeset=71f7f42dee13

Comment 33

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/7ecfeb38e667