Closed
Bug 820472
Opened 12 years ago
Closed 11 years ago
Display a notification in the header when a user is logged in and has outstanding needinfo requests
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 920026
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file)
6.95 KB,
patch
|
glob
:
review-
|
Details | Diff | Splinter Review |
When a user has outstanding needinfo requests specifically for them, then it should display a notification at the top of each page which links to request.cgi. We will need to add a column to the profiles table which is incremented/decremented properly when a user has needinfo set for them. dkl
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #692078 -
Flags: review?(glob)
Comment on attachment 692078 [details] [diff] [review] Patch to show needinfo request count at the top of the page (v1) Review of attachment 692078 [details] [diff] [review]: ----------------------------------------------------------------- i don't think this needs to go in both the header and footer; just place it in the header please. ::: extensions/Needinfo/Extension.pm @@ +45,5 @@ > + } > + > + if (!$dbh->bz_column_info('profiles', 'needinfo_count')) { > + $dbh->bz_add_column('profiles', 'needinfo_count', > + {TYPE => 'INT3', NOTNULL => 1, DEFAULT => 0}); you also need to set the value for needinfo_count based on existing needinfo requests. @@ +158,2 @@ > push(@flags, { id => $flag->id, status => 'X' }); > } needinfo_count isn't updated if the user clears or sets the flag using the normal flag ui. ::: extensions/Needinfo/template/en/default/hook/global/common-links-links-end.html.tmpl @@ +8,5 @@ > + > +[% IF user.id && user.needinfo_count %] > + <span class="needinfo_count_container"> > + <a class="needinfo_count_link" > + href="[% urlbase FILTER none %]/request.cgi?action=queue&type=needinfo&requestee=[% user.login FILTER url_quote %]"> & --> & @@ +9,5 @@ > +[% IF user.id && user.needinfo_count %] > + <span class="needinfo_count_container"> > + <a class="needinfo_count_link" > + href="[% urlbase FILTER none %]/request.cgi?action=queue&type=needinfo&requestee=[% user.login FILTER url_quote %]"> > + Needinfo: [% user.needinfo_count %]</a> needs a filter to pass tests ::: extensions/Needinfo/web/styles/needinfo.css @@ +13,5 @@ > +#header .needinfo_count_link:visited, > +#footer .needinfo_count_link, > +#footer .needinfo_count_link:visited { > + color: #FF8C00;: > +} these colours are very hard to read. please change to something with more contrast, and a little more subtle.
Attachment #692078 -
Flags: review?(glob) → review-
Assignee | ||
Comment 3•11 years ago
|
||
This is dupe effort with bug 920026. dkl
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Updated•5 years ago
|
Component: Extensions: Needinfo → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•