validation on balrog permissions' options doesn't happen

RESOLVED FIXED

Status

Release Engineering
Balrog: Backend
P3
normal
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: bhearsum, Assigned: Ashish Sareen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [balrog])

(Reporter)

Description

4 years ago
Peter found this today - it silently accepts and throws away bad JSON.
1. You're allowed to enter new permissions with the "Options" field blank.

2. Trying to do an update with invalid input to the "Options" field does not complain with an error.

Updated

4 years ago
Priority: -- → P3
Product: mozilla.org → Release Engineering
(Reporter)

Comment 2

4 years ago
This is probably something on the backend...
Component: General Automation → Balrog: Backend
QA Contact: catlee → bhearsum
(Assignee)

Comment 3

a year ago
I can have a look at it. Could you please assign this bug to me ?
(Reporter)

Updated

a year ago
Assignee: nobody → ashish.sareen95
(Reporter)

Comment 4

a year ago
Ashish looked into this and couldn't find any cases where it happened anymore. I dug through blame and it looks like it was fixed by https://github.com/mozilla/balrog/commit/e1940615ffda8b539d7e4ea787dae82ec2027498.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.