validation on balrog permissions' options doesn't happen

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: ashish.sareen95)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [balrog])

Peter found this today - it silently accepts and throws away bad JSON.
1. You're allowed to enter new permissions with the "Options" field blank.

2. Trying to do an update with invalid input to the "Options" field does not complain with an error.
Priority: -- → P3
Product: mozilla.org → Release Engineering
(Reporter)

Comment 2

6 years ago
This is probably something on the backend...
Component: General Automation → Balrog: Backend
QA Contact: catlee → bhearsum
(Assignee)

Comment 3

3 years ago
I can have a look at it. Could you please assign this bug to me ?
(Reporter)

Updated

3 years ago
Assignee: nobody → ashish.sareen95
(Reporter)

Comment 4

3 years ago
Ashish looked into this and couldn't find any cases where it happened anymore. I dug through blame and it looks like it was fixed by https://github.com/mozilla/balrog/commit/e1940615ffda8b539d7e4ea787dae82ec2027498.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.