820533 - Change Downloads Summary string from "+X other current downloads" to "+ X other downloads"

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

I was just talking to Matej Novak about this, and he seems to think that "current" doesn't really add much to what we're trying to convey, and might actually be confusing, since it might be interpreted that these downloads are actually in progress (where in fact, to display this message, we only need at least one download progressing OR paused).

Switching this string to be "+X other downloads" might be more clear.

Also, in shorlander's mock-up, he had a space after the +, so we might want the final string to be:

"+ X other downloads"

Comment 1

[Marco Bonardo [:mak]]

We moved away from "+X other downloads" cause it doesn't represet the fact there are far more than those.
So you click "+5 other downloads", click on it and the library opens showing you 50 or 100 downloads.
I agree "current" is not the proper wording since may involve "in progress", so we need something better to express "session downloads", but I also think "session" concept is complicated to expose in the UI like that, many users are unlikely to understand what a session is.
"recent downloads"?

Comment 2

[Marco Bonardo [:mak]]

soft-blocker, to evaluate

Comment 3

[Marco Bonardo [:mak]]

Stephen, what do you think of

"+ X other recent downloads" ?

Also, do you want the whitespace between the plus sign and the number?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Just talked to Stephen - we're going to go with:

+ X other downloads

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 691963 [details] [diff] [review]
Patch v1

Review of attachment 691963 [details] [diff] [review]:
-----------------------------------------------------------------

I think this will confuse users clicking "+ 2 other downloads" and ending into a 100 downloads list. But I suppose this has been taken into account in the final choice, so I can just cover my eyes :)

you should update this comment that talks about otherDownloads to otherDownloads2:
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/downloads/downloads.dtd#33

Comment 7

[Girish Sharma [:Optimizer]]

then why not think of something like :

+ X downloads from this session 

?

Comment 8

[Marco Bonardo [:mak]]

as I said earlier, "session" is an advanced concept that most users don't understand, wouldn't be less confusing. Let's remove "current" for now, as said, and check feedback.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2 (r+'d by mak)

Good catch - I updated that comment, and the associated string (since the minWidth needed to change to match the new string). Rev'd the string ID as well.

I'll assume I don't need another review for those changes until I hear otherwise.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v3

Whoops - that comment in downloads.dtd should have used "other" instead of "current". Adjusted minWidth.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2a1011fdb5

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ea2a1011fdb5

Comment 13

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly - the downloads summary string is now "X other downloads".


Verified on Windows 7, Ubuntu 12.10 and Mac OS X 10.7.5:
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121217 Firefox/20.0 Build ID: 20121217030850
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20121218 Firefox/20.0 Build ID: 20121218030803
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20121218 Firefox/20.0 Build ID: 20121218030803