Closed
Bug 820576
Opened 12 years ago
Closed 12 years ago
Search suggestion URLs should go directly to URL
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 20
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(2 files, 1 obsolete file)
4.64 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
2.91 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
When typing "maps.g" and you click "maps.google.com", this should open http://maps.google.com directly rather than do a search for "maps.google.com".
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #691071 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #691072 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•12 years ago
|
||
s/viewHolder.suggestionView/viewHolder.userEnteredView/
Attachment #691072 -
Attachment is obsolete: true
Attachment #691072 -
Flags: review?(mark.finkle)
Attachment #691079 -
Flags: review?(mark.finkle)
Comment 4•12 years ago
|
||
Comment on attachment 691071 [details] [diff] [review] Part 1: Move isSearchUrl to StringUtils Let's rename isSearchUrl -> isSearchQuery since a "search url" is kinda weird if you think about it.
Attachment #691071 -
Flags: review?(mark.finkle) → review+
Comment 5•12 years ago
|
||
Comment on attachment 691079 [details] [diff] [review] Part 2: Open URL for suggestions that look like URLs, v2 > if (listener != null) { > String suggestion = ((TextView) v.findViewById(R.id.suggestion_text)).getText().toString(); >- listener.onSearch(engine.name, suggestion); >+ // If we're not clicking the user-entered view (the Add a blank line before the comment
Attachment #691079 -
Flags: review?(mark.finkle) → review+
Comment 6•12 years ago
|
||
I just wanted to give Ian a chance to veto this feature. I have been wanting this for a while, but UX should be aware of the change.
Flags: needinfo?(ibarlow)
Comment 7•12 years ago
|
||
Oh man. I 100% want this. We've talked about it within UX for some time, but I think it just never came up in other conversations. But yes. Please proceed!
Flags: needinfo?(ibarlow)
Comment 8•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #4) > Comment on attachment 691071 [details] [diff] [review] > Part 1: Move isSearchUrl to StringUtils > > Let's rename isSearchUrl -> isSearchQuery since a "search url" is kinda > weird if you think about it. If we're going to make this a string utility function, seems better to just ask "isUrl" since we may not be calling with a search term.
Comment 9•12 years ago
|
||
(In reply to Wesley Johnston (:wesj) from comment #8) > (In reply to Mark Finkle (:mfinkle) from comment #4) > > Comment on attachment 691071 [details] [diff] [review] > > Part 1: Move isSearchUrl to StringUtils > > > > Let's rename isSearchUrl -> isSearchQuery since a "search url" is kinda > > weird if you think about it. > > If we're going to make this a string utility function, seems better to just > ask "isUrl" since we may not be calling with a search term. I considered that too, but in the end I felt answering "isUrl" is much harder than "isSearchQuery" since URLs are tricky beasts and I didn't want "isUrl" to "mostly" work. Also, the code in the method was already designed to answer "isSearchQuery", so it required less work.
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e14b7800ae01 https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce57f5cca0b
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e14b7800ae01 https://hg.mozilla.org/mozilla-central/rev/1ce57f5cca0b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment 12•12 years ago
|
||
Firefox 20.0a1 (2012-12-17) Device: Galaxy Nexus OS: Android 4.1.1 URL Search suggestions go directly to correct URL (steps from Comment 1). Marking bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•