Search suggestion URLs should go directly to URL

VERIFIED FIXED in Firefox 20

Status

()

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 20
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
When typing "maps.g" and you click "maps.google.com", this should open http://maps.google.com directly rather than do a search for "maps.google.com".
(Assignee)

Comment 1

6 years ago
Created attachment 691071 [details] [diff] [review]
Part 1: Move isSearchUrl to StringUtils
Attachment #691071 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

6 years ago
Created attachment 691072 [details] [diff] [review]
Part 2: Open URL for suggestions that look like URLs
Attachment #691072 - Flags: review?(mark.finkle)
(Assignee)

Updated

6 years ago
Blocks: 586885
(Assignee)

Comment 3

6 years ago
Created attachment 691079 [details] [diff] [review]
Part 2: Open URL for suggestions that look like URLs, v2

s/viewHolder.suggestionView/viewHolder.userEnteredView/
Attachment #691072 - Attachment is obsolete: true
Attachment #691072 - Flags: review?(mark.finkle)
Attachment #691079 - Flags: review?(mark.finkle)
Comment on attachment 691071 [details] [diff] [review]
Part 1: Move isSearchUrl to StringUtils

Let's rename isSearchUrl -> isSearchQuery since a "search url" is kinda weird if you think about it.
Attachment #691071 - Flags: review?(mark.finkle) → review+
Comment on attachment 691079 [details] [diff] [review]
Part 2: Open URL for suggestions that look like URLs, v2


>                     if (listener != null) {
>                         String suggestion = ((TextView) v.findViewById(R.id.suggestion_text)).getText().toString();
>-                        listener.onSearch(engine.name, suggestion);
>+                        // If we're not clicking the user-entered view (the

Add a blank line before the comment
Attachment #691079 - Flags: review?(mark.finkle) → review+
I just wanted to give Ian a chance to veto this feature. I have been wanting this for a while, but UX should be aware of the change.
Flags: needinfo?(ibarlow)
Oh man. I 100% want this. We've talked about it within UX for some time, but I think it just never came up in other conversations. 

But yes. Please proceed!
Flags: needinfo?(ibarlow)
(In reply to Mark Finkle (:mfinkle) from comment #4)
> Comment on attachment 691071 [details] [diff] [review]
> Part 1: Move isSearchUrl to StringUtils
> 
> Let's rename isSearchUrl -> isSearchQuery since a "search url" is kinda
> weird if you think about it.

If we're going to make this a string utility function, seems better to just ask "isUrl" since we may not be calling with a search term.
(In reply to Wesley Johnston (:wesj) from comment #8)
> (In reply to Mark Finkle (:mfinkle) from comment #4)
> > Comment on attachment 691071 [details] [diff] [review]
> > Part 1: Move isSearchUrl to StringUtils
> > 
> > Let's rename isSearchUrl -> isSearchQuery since a "search url" is kinda
> > weird if you think about it.
> 
> If we're going to make this a string utility function, seems better to just
> ask "isUrl" since we may not be calling with a search term.

I considered that too, but in the end I felt answering "isUrl" is much harder than "isSearchQuery" since URLs are tricky beasts and I didn't want "isUrl" to "mostly" work. Also, the code in the method was already designed to answer "isSearchQuery", so it required less work.
https://hg.mozilla.org/mozilla-central/rev/e14b7800ae01
https://hg.mozilla.org/mozilla-central/rev/1ce57f5cca0b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20

Comment 12

6 years ago
Firefox 20.0a1 (2012-12-17)
Device: Galaxy Nexus
OS: Android 4.1.1

URL Search suggestions go directly to correct URL (steps from Comment 1). Marking bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.