820601 - mozSocial api for browser tab content

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

We should inject the navigator.mozSocial APIs into any content loaded from a provider.  This would allow their normal web pages to interact better with the social provider content.

A secondary use would be to always inject mozSocial for whitelisted providers to help with issues presented by bug 785540.  In this case, most of the APIs would need to verify the provider is activated before doing anything.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: inject mozSocial on any provider content

This is useful for debugging a provider in a tab using our dev tools

Comment 2

[Shane Caraveo (:mixedpuppy)]

Gavin, this patch would be incredibly useful for debugging/development purposes as well as easing some interactions between pages in a tab and social content (e.g. not relying on localStorage flags).  Otherwise, the first case (debugging/development) could be handled with a pref to allow the injection on tab content.  Do you have any opinion here?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I'm not so comfortable with doing this by default, but putting it behind a hidden pref seems reasonable.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: inject mozSocial on any provider content

if social.browser-tabs is true, we'll inject navigator.mozSocial onto provider pages in browser tabs.

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://tbpl.mozilla.org/?tree=Try&rev=5733977d6d75

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: inject mozSocial on any provider content

fixed patch and feedback.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 755700 [details] [diff] [review]
inject mozSocial on any provider content

Review of attachment 755700 [details] [diff] [review]:
-----------------------------------------------------------------

I think developers might get in a situation where they flip this pref and forget about it, get things working and don't realize it won't work with the pref off..  But if you think it'll will be more useful than confusing, so be it

::: toolkit/components/social/MozSocialAPI.jsm
@@ +53,5 @@
>                                    .getInterface(Ci.nsIWebNavigation)
>                                    .QueryInterface(Ci.nsIDocShell)
>                                    .chromeEventHandler;
> +    // limit injecting into social panels or same-origin browser tabs if
> +    // social.browser-tabs is enabled

comment needs updating with the new pref name

@@ +57,5 @@
> +    // social.browser-tabs is enabled
> +    let allowTabs = false;
> +    try {
> +      allowTabs = containingBrowser.contentWindow == window &&
> +                    Services.prefs.getBoolPref("social.debug.injectIntoTabs");

align the two lines?

@@ +63,3 @@
>  
>      let origin = containingBrowser.getAttribute("origin");
> +    if (!allowTabs && (!origin || origin != doc.nodePrincipal.origin)) {

attachToWindow already checks the origin

Comment 8

[Shane Caraveo (:mixedpuppy)]

Attachment: inject mozSocial on any provider content

feedback implemented

https://tbpl.mozilla.org/?tree=Try&rev=7de13933c346

Comment 9

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a73a0a88d8f9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a73a0a88d8f9