Closed Bug 820622 Opened 13 years ago Closed 13 years ago

Add browser's locale to [Bedrock] generated download button link

Categories

(www.mozilla.org :: Bedrock, defect)

Product:
www.mozilla.org
Component:
Bedrock
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cmore, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: u=dev c=l10n p=)

Current, the download buttons on the PHP and Bedrock site do *not* include the locale in the link to /products/download.html. For example, on the mozilla.org homepage and /firefox/new/ page the buttons point to: https://www.mozilla.org/products/download.html?product=firefox-17.0.1&os=osx&lang=en-US When you to to that URL, the web server does a locale detection and 301 redirects to: https://www.mozilla.org/en-US/products/download.html?product=firefox-17.0.1&os=osx&lang=en-US Why is this not good? 1) We are doing two request per button click and doubling the requests to the web server/caching server. 2) Google Analytics has in-page analytics and measure conversions on pages with links. Since the URL of the buttons do not match the URL of the locale aware version, Google Analytics does not show conversions for those button. Can the locale of the user (regardless of the locale of the page) be added to the absolute path of the download buttons instead of making the web server redirect /products/download.html to /locale/products/download.html? This is part of the build.download_link in https://github.com/mozilla/bedrock/blob/master/apps/mozorg/templates/mozorg/download_buttons/base.html and https://github.com/mozilla/bedrock/blob/master/apps/mozorg/helpers/download_buttons.py Since we are rebuilding the buttons now, we should decide if we want to do this as part of that project.
Blocks: download-buttons
This seems like something that should be happening regardless of the analytics help. I think we should do this as part of the new buttons on bedrock work. For the PHP side perhaps we should have a separate bug? I don't think the php-side buttons are being worked on for this effort are they?
On the php side, this is only for the en-US pages, localized pages have a download link with a locale code in the path: http://www.mozilla.org/pt-BR/firefox/new http://www.mozilla.org/pt-BR/download/?product=firefox-17.0.1&os=linux&lang=pt-BR
Yes, this should block the release of the new download buttons in bedrock. Regardless of analytics, we should do it.
(In reply to Pascal Chevrel:pascalc from comment #2) > On the php side, this is only for the en-US pages, localized pages have a > download link with a locale code in the path: > http://www.mozilla.org/pt-BR/firefox/new > http://www.mozilla.org/pt-BR/download/?product=firefox-17.0. > 1&os=linux&lang=pt-BR Good call! For once, a non-en-US page is doing something better than the en-US version. :)
Whiteboard: u=dev c=l10n p=
You need to log in before you can comment on or make changes to this bug.