Call waiting incomingEnd button sends a hold for the active call first instead of ending the active call

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: anshulj, Assigned: etienne)

Tracking

unspecified
B2G C3 (12dec-1jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
There is a GCF test case 31.3.1.2.1 that fails because during a call waiting scenario when ending the active call and accepting the incoming call the active call should be ended but Gaia is first sending the hold for the active call followed by the end for the active call. This is due to the fact that endAndAnswer method in oncall.js first calls holdAndAnswer and then calls callToEnd.hangup.
(Reporter)

Updated

6 years ago
Blocks: 802677
blocking-basecamp: --- → ?
Hsin-Yi, tentatively assigning to you.  Please reassign as appropriate :).
Assignee: nobody → htsai
blocking-basecamp: ? → +
Priority: -- → P1
Status: UNCONFIRMED → NEW
Ever confirmed: true
I investigated this issue and came to the same conclusion with Anshul (comment 0). I don't why in gaia/oncall.js we hold the first call then hang it up, instead of hanging it up directly. Maybe Etienne could help answer my question :) 

I would say it's a gaia issue so I reassign to Etienne. If we realize this issue should be fixed in gecko, then I'd love to take this!
Assignee: htsai → etienne
Component: General → Gaia::Dialer
Target Milestone: --- → B2G C3 (12dec-1jan)
Created attachment 691685 [details] [diff] [review]
Hang up the current call and then answer the waiting call

Tested in the emulator and works, but I don't have the ability to test on hardware atm.
Assignee: etienne → jones.chris.g
Attachment #691685 - Flags: review?(etienne)
(Assignee)

Comment 4

6 years ago
Comment on attachment 691685 [details] [diff] [review]
Hang up the current call and then answer the waiting call

Not sure why, and didn't find an easy fix, but the second call never gets picked up...
Attachment #691685 - Flags: review?(etienne) → review-
(Assignee)

Comment 5

6 years ago
STR:
- apply the patch from comment 3
- call your voicemail
- from a second phone call the b2g phone
- tap the end and answer button

Expected:
- the voicemail call is ended
- the incoming call is answered

Actual:
- the voicemail call is ended
(I can hear the ringing tone on the second phone, confirming that it is indeed not picked up.)

Tested on a unagi with a mozilla-beta gecko form yesterday.
I also tried to wait for the ondisconnecting on the voicemail call before calling answer on the incoming call but no luck.

I there a RIL-level issue preventing this patch from working?
Flags: needinfo?(htsai)
(In reply to Etienne Segonzac (:etienne) from comment #5)
> STR:
> - apply the patch from comment 3
> - call your voicemail
> - from a second phone call the b2g phone
> - tap the end and answer button
> 
> Expected:
> - the voicemail call is ended
> - the incoming call is answered
> 
> Actual:
> - the voicemail call is ended
> (I can hear the ringing tone on the second phone, confirming that it is
> indeed not picked up.)
> 
> Tested on a unagi with a mozilla-beta gecko form yesterday.
> I also tried to wait for the ondisconnecting on the voicemail call before
> calling answer on the incoming call but no luck.
> 
> I there a RIL-level issue preventing this patch from working?

Hi Etienne,

The patch looks good, overall, but I realized that we should wait for the response from the network before sending the next request. 

So, if I modify the code as 

  callToEnd.addEventListener('disconnected', function disconnected() {
    callToEnd.removeEventListener('disconnected', disconnected);
    callToAnswer.answer();
  });
 callToEnd.hangUp();

I can see what we are expecting.
Flags: needinfo?(htsai)
(Assignee)

Comment 7

6 years ago
Created attachment 692248 [details]
Pointer to gaia PR 7019

Thanks Hsin-Yi! Working perfectly.
Assignee: jones.chris.g → etienne
Attachment #691685 - Attachment is obsolete: true
Attachment #692248 - Flags: review?(francisco.jordano)
Comment on attachment 692248 [details]
Pointer to gaia PR 7019

Small change, love it :)
Attachment #692248 - Flags: review?(francisco.jordano) → review+
(Assignee)

Comment 9

6 years ago
https://github.com/mozilla-b2g/gaia/commit/8a3c61188a37d1a0961ccbf286d3d1c4c763a62a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 10

6 years ago
Verified fixed Unagi build 20130103070201
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.