Closed Bug 820691 Opened 12 years ago Closed 12 years ago

JS GDB pretty-printers: test harness should not use GDB's --python option

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20

People

(Reporter: jimb, Unassigned)

Details

Attachments

(1 file)

Don't use GDB's --python option to run JS pretty-printer tests; newer GDBs don't have that option.
3.17 KB, patch
sfink
: review+
Details | Diff | Splinter Review 
js/src/gdb/run-tests.py uses GDB's --python option to tell GDB to run each test script. However, the current GDB sources don't implement any --python option, nor is it present on Gentoo Linux.

js/src/gdb-run-tests.py should be changed to run the tests using the --eval-command option, which is more widely supported.
Attachment #691223 - Flags: review?(sphink)
Attachment #691223 - Flags: review?(sphink) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdee421b26c6
Status: NEW → ASSIGNED
Flags: in-testsuite+
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/bdee421b26c6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: