Closed
Bug 820726
Opened 13 years ago
Closed 13 years ago
IonMonkey: Add loop header/backedge asserts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 820676
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
13 years ago
1.77 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Tightens an assert and adds some other ones that would have made the problem in bug 820676 a lot more obvious.
Nicolas r+'ed on IRC.
|
Assignee | |
Updated•13 years ago
|
Attachment #691249 -
Flags: review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Before the edge splitting pass, these asserts don't always hold (e.g. a backedge can have two successors) and these asserts break the Ion spew. So I'm not landing this for now.
|
||
Comment 3•13 years ago
|
||
I incorporated similar asserts into bug 820676.
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to Niko Matsakis from comment #3)
> I incorporated similar asserts into bug 820676.
Thanks again.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•