B2G MMS: Don't deactivate the MMS network so often which is a burden for consecutive MMS HTTP requests.

RESOLVED FIXED in Firefox 21

Status

Firefox OS
General
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Gene Lian (I already quit Mozilla), Assigned: Gene Lian (I already quit Mozilla))

Tracking

unspecified
B2G C4 (2jan on)
ARM
Gonk (Firefox OS)
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:leo+, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Details

Attachments

(2 attachments, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 691278 [details] [diff] [review]
Patch

Hi Vicamo,

It'd be better to review and check in the bug 817474 because this one should be on top of that. This patch set another 30s timer to delay the time of deactiving the MMS network, since the MMS requests often come consecutively in a short time, so that we won't setup/deactivate the MMS network frequently.
Attachment #691278 - Flags: review?(vyang)
(Assignee)

Comment 2

6 years ago
Created attachment 691705 [details] [diff] [review]
Patch 1.1

Minor rebase because of bug 817474.
Attachment #691278 - Attachment is obsolete: true
Attachment #691278 - Flags: review?(vyang)
Attachment #691705 - Flags: review?(vyang)
(Assignee)

Comment 3

6 years ago
Created attachment 692865 [details] [diff] [review]
Patch 1.2

Minor rebase because of bug 817474.
Attachment #691705 - Attachment is obsolete: true
Attachment #691705 - Flags: review?(vyang)
Attachment #692865 - Flags: review?(vyang)
(Assignee)

Comment 4

6 years ago
Hi Vicamo, sorry for bugging. Ping a bit.

Just letting you know that it'd be appreciated if I can have your review for this before going to be on vacation. Thanks! :)
(Assignee)

Comment 5

6 years ago
Sorry for bugging but I'd like to ping a bit on this since one week has passed. ;)
Comment on attachment 692865 [details] [diff] [review]
Patch 1.2

Review of attachment 692865 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Gene, sorry it takes so long, but this patch seems to leave mmsConnRefCount & isProxyFilterRegistered with incorrect values when the timer is cancelled in line 736 directly.
Attachment #692865 - Flags: review?(vyang)
(Assignee)

Comment 7

6 years ago
Created attachment 697827 [details] [diff] [review]
Patch 1.3
Attachment #692865 - Attachment is obsolete: true
Attachment #697827 - Flags: review?(vyang)
(Assignee)

Comment 8

6 years ago
Created attachment 697842 [details] [diff] [review]
Patch 1.4
Attachment #697827 - Attachment is obsolete: true
Attachment #697827 - Flags: review?(vyang)
Attachment #697842 - Flags: review?(vyang)
Comment on attachment 697842 [details] [diff] [review]
Patch 1.4

Review of attachment 697842 [details] [diff] [review]:
-----------------------------------------------------------------

:)
Attachment #697842 - Flags: review?(vyang) → review+
Someday we should move all these connection management code into NetworkManager or something like that. Hopefully we can have a solid, global and easy-to-use connection management in the future :)
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/47260562baa5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

6 years ago
This bug relates to MMS features and needs to be tagged as leo+ so that we can uplift it into the b2g-18 branch.
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
(Assignee)

Comment 15

5 years ago
https://hg.mozilla.org/releases/mozilla-b2g18/rev/4a9cd708101d
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
The entire set of clian's pushes was backed out for multiple reasons.
https://tbpl.mozilla.org/?tree=Mozilla-B2g18&rev=a0b06192f882

1.) The tree rules are clear that you are not to land on top of bustage. At the time you pushed, both B2G Mn and B2G xpcshell had bustage from prior commits that hadn't been backed out yet.
2.) The tree rules are also clear that you are to watch your pushes for any bustage and handle them accordingly. mozilla-inbound is the ONLY tree where this rule does not apply.
3.) Even after the earlier bustage was backed out, something in one of your many pushes was causing further B2G Mn failures as shown in the log below.
https://tbpl.mozilla.org/php/getParsedLog.php?id=20424173&tree=Mozilla-B2g18
4.) This isn't cause for backout by itself, but it is also strongly preferred to not push each commit individually as our build and testing resources are limited and doing so stretches them even thinner. Please limit your number of pushes as much as possible unless you have good reason for keeping them separate.
status-b2g18: fixed → affected
status-firefox20: --- → wontfix
status-firefox21: --- → fixed
Target Milestone: --- → B2G C4 (2jan on)

Updated

5 years ago
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.