Closed
Bug 820865
Opened 12 years ago
Closed 9 years ago
Clean up Sync strings
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: rnewman, Assigned: ananuti, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
|
1.91 KB,
patch
|
ananuti
:
review+
|
Details | Diff | Splinter Review |
/services/sync/locales/en-US/sync.properties
remote.notification.label = Recent desktop tabs will be available once they sync
This isn't used anywhere. There are probably more. We should find the strings that we don't use, determine which ones should be removed permanently, and remove them -- otherwise they're just more work for l10n.
|
Assignee | |
Comment 1•12 years ago
|
||
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 691615 [details] [diff] [review] patch Review of attachment 691615 [details] [diff] [review]: ----------------------------------------------------------------- One string I'd like to keep. Please make sure that this builds, and that Sync, about:sync-tabs, and bad credentials still work (i.e., throws appropriate yellow bars) before landing. ::: services/sync/locales/en-US/sync.properties @@ -18,2 @@ > error.login.title = Error While Signing In > -error.login.description = Sync encountered an error while connecting: %1$S. Please try again. Ugh. This is actually pretty intertwined; Sync doesn't really have a login concept any more, but the login notifications, statuses, and UI stuff are still kinda present. All of the login/logout stuff needs to go, and then we can kill more of these strings. @@ -35,5 @@ > error.sync.tryAgainButton.label = Sync Now > error.sync.tryAgainButton.accesskey = S > warning.sync.quota.label = Approaching Server Quota > warning.sync.quota.description = You are approaching the server quota. Please review which data to sync. > -error.sync.quota.label = Server Quota Exceeded Let's leave this one. Evidently it's not being used when it should.
Attachment #691615 -
Flags: review?(rnewman) → review+
|
||
Updated•10 years ago
|
Mentor: rnewman
Whiteboard: [good first bug][mentor=rnewman] → [good first bug]
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #691615 -
Attachment is obsolete: true
Attachment #8666299 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e91afa57bde7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
|
||
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•