Clean up Sync strings

RESOLVED FIXED in Firefox 44

Status

Cloud Services
Firefox Sync: UI
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: rnewman, Assigned: Ekanan Ketunuti, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

1.91 KB, patch
Ekanan Ketunuti
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
/services/sync/locales/en-US/sync.properties
    remote.notification.label = Recent desktop tabs will be available once they sync

This isn't used anywhere. There are probably more. We should find the strings that we don't use, determine which ones should be removed permanently, and remove them -- otherwise they're just more work for l10n.
Blocks: 820781
(Assignee)

Comment 1

5 years ago
Created attachment 691615 [details] [diff] [review]
patch
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #691615 - Flags: review?(rnewman)
(Reporter)

Comment 2

5 years ago
Comment on attachment 691615 [details] [diff] [review]
patch

Review of attachment 691615 [details] [diff] [review]:
-----------------------------------------------------------------

One string I'd like to keep. Please make sure that this builds, and that Sync, about:sync-tabs, and bad credentials still work (i.e., throws appropriate yellow bars) before landing.

::: services/sync/locales/en-US/sync.properties
@@ -18,2 @@
>  error.login.title = Error While Signing In
> -error.login.description = Sync encountered an error while connecting: %1$S.  Please try again.

Ugh. This is actually pretty intertwined; Sync doesn't really have a login concept any more, but the login notifications, statuses, and UI stuff are still kinda present.

All of the login/logout stuff needs to go, and then we can kill more of these strings.

@@ -35,5 @@
>  error.sync.tryAgainButton.label = Sync Now
>  error.sync.tryAgainButton.accesskey = S
>  warning.sync.quota.label = Approaching Server Quota
>  warning.sync.quota.description = You are approaching the server quota. Please review which data to sync.
> -error.sync.quota.label = Server Quota Exceeded

Let's leave this one. Evidently it's not being used when it should.
Attachment #691615 - Flags: review?(rnewman) → review+
(Reporter)

Updated

5 years ago
Blocks: 821143
Mentor: rnewman@mozilla.com
Whiteboard: [good first bug][mentor=rnewman] → [good first bug]
(Assignee)

Comment 3

2 years ago
Created attachment 8666299 [details] [diff] [review]
Unbitrotted patch
Attachment #691615 - Attachment is obsolete: true
Attachment #8666299 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e91afa57bde7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e91afa57bde7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.