821007 - mozmill should log request/response bodies of update requests

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[[e-mail] (:bhearsum)]

Spawned out of bug 817688, comment #27. Not sure how to do this exactly, but it would be extremely helpful when diagnosing update problems that could be server related.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not specifically a mozmill issue but more software update test related. Which connection we would have to log specifically. I ask because we can't log anything which would blow up the log drastically.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Henrik Skupin (:whimboo) from comment #1)
> Not specifically a mozmill issue but more software update test related.
> Which connection we would have to log specifically. I ask because we can't
> log anything which would blow up the log drastically.

Huge logs is better than logs that don't have enough info. I don't think we should block this on special hooks in the updater code.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So we could observe 'http-on-examine-response' by setting the observer before checking for updates and disable it right after the update has been downloaded. The additional information shouldn't be that much in this case. Not sure yet if we should add it to the report or the console log only.

Ben, what's your take on that proposal? Does it sound ok?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

See also https://developer.mozilla.org/en/HTTP_Logging. DNS logging would be useful to identify the CDN being used, if it provides the IP address that download.cdn.mozilla.net resolves to.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Henrik Skupin (:whimboo) from comment #3)
> So we could observe 'http-on-examine-response' by setting the observer
> before checking for updates and disable it right after the update has been
> downloaded. The additional information shouldn't be that much in this case.
> Not sure yet if we should add it to the report or the console log only.
> 
> Ben, what's your take on that proposal? Does it sound ok?

I don't fully understand, what that means, but if gets us full requests and responses, sounds great!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreea, can we please get an update? This sprint entry is waiting for 2 months now!

Comment 7

[Andreea Matei [:AndreeaMatei]]

Sorry for that, I have focused on P1 bugs and other P2 that were failures mainly, above this that is an enhancement. Also now I'm working with Daniela on the software update issue for Windows 8.
I will start on it today, maybe get some more clarity over Ask an Expert meeting regarding the steps here and have a patch ready soon.

Comment 8

[Andreea Matei [:AndreeaMatei]]

We have decided to go with HTTP log as Nick Thomas suggested, filed the issue under mozmill-ci for that, you can find it here:
https://github.com/mozilla/mozmill-ci/issues/229