821018 - XML test output fails if there are tests that have been skipped

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

Traceback (most recent call last):
  File "/var/jenkins/workspace/b2g.gaia.unagi/.env/bin/gaiatest", line 9, in <module>
    load_entry_point('gaiatest==0.4', 'console_scripts', 'gaiatest')()
  File "/var/jenkins/workspace/b2g.gaia.unagi/gaiatest/runtests.py", line 17, in main
    cli(runner_class=GaiaTestRunner)
  File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 702, in cli
    runner = startTestRunner(runner_class, options, tests)
  File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 697, in startTestRunner
    runner.run_tests(tests, testtype=options.type)
  File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 369, in run_tests
    f.write(self.generate_xml(self.results))
  File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 528, in generate_xml
    _extract_xml(*tup, result='error')
  File "/var/jenkins/workspace/b2g.gaia.unagi/.env/local/lib/python2.7/site-packages/marionette_client-0.5.11-py2.7.egg/marionette/runtests.py", line 493, in _extract_xml
    testcase.setAttribute('time', str(test.duration))
AttributeError: 'TestSettings' object has no attribute 'duration'

This occurs because test.duration is defined in tearDown, but tearDown isn't always called for skipped tests, or tests that fail in setUp.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: fix this

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 691525 [details] [diff] [review]
fix this

Review of attachment 691525 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.  I'm going to bump the setup.py version and then push this to pypi as well.

Comment 3

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/652e6b974c13

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5b0d8f23de9f

Comment 5

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/releases/mozilla-b2g18/rev/516c1b407c93

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/652e6b974c13