821065 - Allow listeners to listen all event types

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Event listeners need a way to observer all messages similar to observer service.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Got any implementation details in mind?  I'm not sure a special `""` or `"*"` event would work well, so all can see is a new method like `onAny`.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Probably "*" to be consistent with observer service (kind of regret pushing you towards "" for prefs). I do have patch somewhere it was part of refactoring work & have created this bug to separate individual changes from that refactoring.

I'll submit pull request once I'll get my hands on this (should be soon).

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/901

Pointer to Github pull-request

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

No longer sure it's still relevant since we did just fine without it. If turns we need it we can reopen and land attached patch.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/434f0e68712f80a6de61768793cd15f910c26a81
Bug 821065 - Add wildcard event.

https://github.com/mozilla/addon-sdk/commit/951828940c9dd457c75b8f76592c0e8b1b9cebe5
Merge pull request #901 from Gozala/bug/listen-to-all@821065

Bug 821065 - Add wildcard event. r=@ZER0

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

We went back and merged this in, marked as fix, to allow event/utils#pipe work with general events

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f3f791b18b84c563407cc7a70c95b267d5732571
Revert "Bug 821065 - Add wildcard event."

This reverts commit 434f0e68712f80a6de61768793cd15f910c26a81.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Reverted back out

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: GH PR 1274

Updated event wildcard, removing fixes in place previously to have similar behaviour, and removing to prevent duplicates occuring, breaking tests

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0bf57fcb8bde9ddd98af70ec2b6cec8a2d2e9829
Bug 821065 - Add wildcard event listeners, remove hacks that were work arounds fro this

https://github.com/mozilla/addon-sdk/commit/226419e9ec3bca3587c2eaccfa8b7aeb9ddd7da0
Merge pull request #1274 from jsantell/add-wildcard

Fix Bug 821065 - Add wildcard event listeners, remove hacks that were work arounds in workers, r=@gozala