Event listeners need a way to observer all messages similar to observer service.
Summary: Allow listeners to all event types → Allow listeners to listen all event types
Got any implementation details in mind? I'm not sure a special `""` or `"*"` event would work well, so all can see is a new method like `onAny`.
OS: Mac OS X → All
Hardware: x86 → All
Probably "*" to be consistent with observer service (kind of regret pushing you towards "" for prefs). I do have patch somewhere it was part of refactoring work & have created this bug to separate individual changes from that refactoring. I'll submit pull request once I'll get my hands on this (should be soon).
Assignee: nobody → rFobic
Created attachment 729669 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/901 Pointer to Github pull-request
Attachment #729669 - Flags: review?(zer0)
Attachment #729669 - Flags: review?(zer0) → review+
No longer sure it's still relevant since we did just fine without it. If turns we need it we can reopen and land attached patch.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/434f0e68712f80a6de61768793cd15f910c26a81 Bug 821065 - Add wildcard event. https://github.com/mozilla/addon-sdk/commit/951828940c9dd457c75b8f76592c0e8b1b9cebe5 Merge pull request #901 from Gozala/bug/listen-to-all@821065 Bug 821065 - Add wildcard event. r=@ZER0
We went back and merged this in, marked as fix, to allow event/utils#pipe work with general events
Resolution: WONTFIX → FIXED
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/f3f791b18b84c563407cc7a70c95b267d5732571 Revert "Bug 821065 - Add wildcard event." This reverts commit 434f0e68712f80a6de61768793cd15f910c26a81.
Reverted back out
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 824306 [details] GH PR 1274 Updated event wildcard, removing fixes in place previously to have similar behaviour, and removing to prevent duplicates occuring, breaking tests
Attachment #824306 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/0bf57fcb8bde9ddd98af70ec2b6cec8a2d2e9829 Bug 821065 - Add wildcard event listeners, remove hacks that were work arounds fro this https://github.com/mozilla/addon-sdk/commit/226419e9ec3bca3587c2eaccfa8b7aeb9ddd7da0 Merge pull request #1274 from jsantell/add-wildcard Fix Bug 821065 - Add wildcard event listeners, remove hacks that were work arounds in workers, r=@gozala
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.