821121 - MediaDecoder::Statistics::playbackRate should be renamed to avoid confusion with HTMLMediaElement.playbackRate

Status: RESOLVED INACTIVE

(Core :: Audio/Video: Playback, defect)

Description

[Steve Workman [:sworkman] (INACTIVE)]

From cpearce in bug 820588 comment 2:

"It would be good if you could rename the instances of playbackRate that refer to the rate at which bytes are consumed for decode/playback to something else, so that we avoid confusion with the user-settable HTMLMediaElement.playbackRate which refers to the rate at which the playback clock runs."

"Instead of calling this "playback" rate, I'd rather call this "data decode" rate, or "data consumption" rate; we recently added support for HTMLMediaElement.playbackRate, which allows users/authors/Javascript to speed up the rate at which media is played back (unsurprisingly) and it would be good to not confuse these two concepts."

Comment 1

[Steve Workman [:sworkman] (INACTIVE)]

Chris, I can do this no problem, but it looks like it's the computed bitrate of the media and not the actual rate of decode or consumption. UpdatePlaybackRate() updates this value when the media duration changes or the length of the data changes, e.g. in NotifyDataEnded(), or after AdvanceVideoFrame() for 'infinite' streams.

So, how about something like UpdateComputedBitrate() or UpdateDerivedBitrate?
mPlaybackPosition can stay the same - it seems accurately named.
mPlaybackRate could be mDerivedRate.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Let's go with "computed bitrate", since that term is already used in a few places in the comments already. Thanks!

Comment 3

[Steve Workman [:sworkman] (INACTIVE)]

Re-assigning this to Chris as I don't think I'll be able to find time to do it.

Comment 4

[Nils Ohlmeier [:drno]]

Mass closing do to inactivity.
Feel free to re-open if still needed.