821143 - Eliminate login concept from Sync

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Richard Newman [:rnewman]]

There's lots of code that tries to handle login error notifications and such, and that ties us (and poor localizers) to strings.

FxA should kill this.

Comment 1

[Richard Newman [:rnewman]]

See Bug 820865; we should kill strings as we go.

Comment 2

[Chris Karlof [:ckarlof]]

markh, given all the work we've done on removing error bars and such, do you think there's anything else actionable here or can we close this?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Chris Karlof [:ckarlof] from comment #2)
> markh, given all the work we've done on removing error bars and such, do you
> think there's anything else actionable here or can we close this?

I think we should keep it and eventually do it - the existing code is too complex and often wrong. I think it means that we still keep login as a concept, but remove login as a "state" - ie, drop the concept of "login start", "login done", "login error" etc, and roll them up into "sync start", "sync error" etc.