821218 - [SMS] Can't select certain messages in message deletion selection screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Walter Chen[:ypwalter][:wachen]]

*Phone: Unagi
2012-12-12
https://releases.mozilla.com/b2g/

*How to reproduce:
  0. send an message to phone A
  1. receive an message from phone A
  2. send an message to phone A
  3. click Edit icon on upper-right corner of messages screen
  4. try to select the incoming message

*Expected Result: 
    Incoming messages can be selected

*Actual Result:
    Incoming messages can't be selected

*note: only incoming messages after outgoing message can't be selected. also, please do notice that if you use select all, you can select them.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, C3, P2- regression for broken feature

Comment 2

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 3

[Borja Salguero [:borjasalguero]]

Hi [:michalbe] ! This bug is fixed in the following PR #6996 , due to applying new Building Blocks of Lists to SMS App, it is fixed automatically! So if you want, once the PR of BB was landed, we could retest it again and check that everything works as expected, Wdyt? Thanks for your work!

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 692098 [details]
patch

Looks nice to me, but my understanding is that is gonna change whit the new building blocks

I'd like :borjasalguero to review it, cause he is the one taking care of SMS at the moment

Comment 5

[Michał Budzyński (:michalbe)]

It's a pity that you didn't checked it on Bz yesterday, I thought that noone is working on it. When do you expect your patch to land?

Comment 6

[Borja Salguero [:borjasalguero]]

Im really sorry about it... I dind't realize that you were working on it :(. The bug is being reviewed and it's bb+, so I hope to have it ready asap! Again thanks for your work and sorry again for the missunderstanding.

Comment 7

[Michał Budzyński (:michalbe)]

Np. I assume that you BBlocks patches will fix #821221 as well?

Comment 8

[Borja Salguero [:borjasalguero]]

Nop! It's a problem that it's still reproducible with BB :(.

Comment 9

[Borja Salguero [:borjasalguero]]

This one should be working due to BB are landed! Closing. If you find some issue with it, dont hesitate to reopen it. Thanks!

Comment 10

[Walter Chen[:ypwalter][:wachen]]

https://www.youtube.com/watch?v=3J-5SyaU2GM

It can still be reproduced.
The selection of messages kind of working.
However, the offset is a little bit off for some reasons

As you see in the video, if you clicked in right checkbox, it won't react.
If you click a little bit off, it works sometimes.

Comment 11

[Michał Budzyński (:michalbe)]

:borjasalguero Maybe we can try my fix now if you'll confirm that your's not working?

Comment 12

[Borja Salguero [:borjasalguero]]

[:michalbe] Please Gaia version

Comment 13

[Michał Budzyński (:michalbe)]

I don't think I understand what do you mean.

Comment 14

[Fernando Campo (:fcampo)]

Probably asking for build/gaia version the test has been made with, so my guess is that the question was really pointed at Walter Chen instead of you Michał

Comment 15

[Borja Salguero [:borjasalguero]]

[:michalbe] My fault, I was trying to ask Walter about the Gaia/Gecko version.

Comment 16

[Walter Chen[:ypwalter][:wachen]]

https://releases.mozilla.com/b2g/
2012-12-12 build

Comment 17

[Borja Salguero [:borjasalguero]]

Hi Walter, 
This is a quite old version, could you try again with a most recent one? Because this issue was fixed some days ago, and your version is so old. Thanks!

Comment 18

[Walter Chen[:ypwalter][:wachen]]

This bug happened in 2012-12-12. Even if this issue goes away, we still need to know what happened, right?

I tried it on  2012-12-19 18:49:40 PST with most recently build (2012-12-18 build). And, it still kind of reproducible in another way which I stated in comment 10. I attached the video. Did you looked at my comment first, think about it, and then ask me for info? Please do take a careful look on my original post and my following comment.

Comment 19

[Michał Budzyński (:michalbe)]

whats the status of this one now? Anyone working on it?

Comment 20

[Borja Salguero [:borjasalguero]]

With the following (2012-12-23 Build and latest Gaia):
Gaia revision:"e790b7f4ff82cbd3c01297bc30c31b7fccc07ecb"
Gecko revision:"bae67f29dfa16eb7d3904b8bfabd87099d4a52d2"

Is not reproducible. Probably your build did not contain the patch https://github.com/mozilla-b2g/gaia/pull/6996 due to was landed in master 2012-12-17 and your Build was 2012-12-18 build. I've recorded a video with the commits added above and you can see the result. I've tested as well clicking inside/outside the checkbox, and it's working properly due to the whole area is clickable. Please could you try again? Thanks a lot! And sorry for the misunderstandings, sometimes it's hard to reproduce the bug of check if it's fixed because the build versions.

Video:
http://youtu.be/j_fqDlnugyw

Comment 22

[Walter Chen[:ypwalter][:wachen]]

Hi, I think it is fixed and verified as for 2012-12-23 build from https://releases.mozilla.com/b2g/. 

Verified fixed