821229 - The virtual keyboard is dismissed on first match when using Find in Page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Nightly 20.0a1 2012-12-12
Samsung Galaxy Tab 2 7.0 (Android 4.0.4)

Steps to reproduce:
1) Go to any web page
2) Open Find in Page and start typing a search term

Expected results:
The first word matching the search is highlighted but the keyboard is dismissed only when the user taps the next arrow

Actual results:
The keyboard is dismissed on first match, even on the first letter entered match

Notes:
Issue is not reproducible on Aurora or Beta.

Comment 1

[Aaron Train [:aaronmt]]

Bug 760087 all over again?

See old patch: https://bugzilla.mozilla.org/attachment.cgi?id=630766&action=diff

Jim, is this a regression from bug 815430, or your re-write?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

This is as intended

Comment 3

[Aaron Train [:aaronmt]]

This was mis-interpreted and is not working as intended. The keyboard is dismissed far too early here and is a regression.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Last good: 20121205
First bad: 20121206

Comment 6

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-12-05&enddate=2012-12-06

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't show/hide VKB when Gecko view doesn't have focus (v1)

Find In Page can cause focus changes and corresponding notifyIMEEnabled calls, which make us show/hide the keyboard. This patch checks whether the Gecko view has focus first before showing/hiding the keyboard. When Find In Page is active the focus is on the find text field, so we end up not showing/hiding the keyboard unintentionally.

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 693129 [details] [diff] [review]
Don't show/hide VKB when Gecko view doesn't have focus (v1)

Review of attachment 693129 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: mobile/android/base/GeckoInputConnection.java
@@ +519,5 @@
>  
> +        View v = getView();
> +        if (v == null || !v.hasFocus()) {
> +            return;
> +        }

Please add a brief comment describing how this check handles "Find In Page" focus bug.

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2ee611a3e23

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d2ee611a3e23

Comment 11

[Ioana Chiorean]

Firefox 20.0a1 (2012-11-19)
Device: Galaxy Nexus
OS: Android 4.1.1 

This is not reproducible following steps mentioned in Comment#1 on latest Nightly. Marking bug as VERIFIED FIXED.