Closed Bug 821236 Opened 11 years ago Closed 11 years ago

Remove some unused functions that use nsISupportsArray and replace some instances of nsISupportsArray with alternatives

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 20.0

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

The following functions/methods are unused but use nsISupportsArray, we should just drop them:

- nsIMsgFolder::getExpansionArray
- nsMsgRDFDataSource::GetTransactionManager

I'm also replacing the nsISupportsArray instances for:

- nsMsgResultElement::m_valueList

and in these files where nsISupportsArray has been used for window.open arguments:

- nsMessengerBootstrap.cpp
- nsMessengerWinIntegration.cpp
- nsMsgProgress.cpp
Attached patch The fixSplinter Review
I guess it helps to attach the patch and request review ;-)
Attachment #691753 - Flags: review?(neil)
Status: NEW → ASSIGNED
Attachment #691753 - Flags: review?(neil) → review+
https://hg.mozilla.org/comm-central/rev/bdf948453896
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
> - nsMessengerWinIntegration.cpp
I had to add:
#include "nsIMutableArray.h"
to this file to get it to compile.
I compiled on Linux, so I didn't catch that :-(
You need to log in before you can comment on or make changes to this bug.