Closed
Bug 821236
Opened 11 years ago
Closed 11 years ago
Remove some unused functions that use nsISupportsArray and replace some instances of nsISupportsArray with alternatives
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 20.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
10.80 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
The following functions/methods are unused but use nsISupportsArray, we should just drop them: - nsIMsgFolder::getExpansionArray - nsMsgRDFDataSource::GetTransactionManager I'm also replacing the nsISupportsArray instances for: - nsMsgResultElement::m_valueList and in these files where nsISupportsArray has been used for window.open arguments: - nsMessengerBootstrap.cpp - nsMessengerWinIntegration.cpp - nsMsgProgress.cpp
Assignee | ||
Comment 1•11 years ago
|
||
I guess it helps to attach the patch and request review ;-)
Attachment #691753 -
Flags: review?(neil)
Updated•11 years ago
|
Attachment #691753 -
Flags: review?(neil) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/bdf948453896
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
Comment 3•11 years ago
|
||
> - nsMessengerWinIntegration.cpp
I had to add:
#include "nsIMutableArray.h"
to this file to get it to compile.
Comment 4•11 years ago
|
||
I compiled on Linux, so I didn't catch that :-(
You need to log in
before you can comment on or make changes to this bug.
Description
•