Remove some unused functions that use nsISupportsArray and replace some instances of nsISupportsArray with alternatives

RESOLVED FIXED in Thunderbird 20.0

Status

MailNews Core
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 20.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The following functions/methods are unused but use nsISupportsArray, we should just drop them:

- nsIMsgFolder::getExpansionArray
- nsMsgRDFDataSource::GetTransactionManager

I'm also replacing the nsISupportsArray instances for:

- nsMsgResultElement::m_valueList

and in these files where nsISupportsArray has been used for window.open arguments:

- nsMessengerBootstrap.cpp
- nsMessengerWinIntegration.cpp
- nsMsgProgress.cpp
(Assignee)

Comment 1

5 years ago
Created attachment 691753 [details] [diff] [review]
The fix

I guess it helps to attach the patch and request review ;-)
Attachment #691753 - Flags: review?(neil)

Updated

5 years ago
Status: NEW → ASSIGNED

Updated

5 years ago
Attachment #691753 - Flags: review?(neil) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/comm-central/rev/bdf948453896
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0

Comment 3

5 years ago
> - nsMessengerWinIntegration.cpp
I had to add:
#include "nsIMutableArray.h"
to this file to get it to compile.

Comment 4

5 years ago
I compiled on Linux, so I didn't catch that :-(
You need to log in before you can comment on or make changes to this bug.