Last Comment Bug 821236 - Remove some unused functions that use nsISupportsArray and replace some instances of nsISupportsArray with alternatives
: Remove some unused functions that use nsISupportsArray and replace some insta...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 20.0
Assigned To: Mark Banner (:standard8) (afk until 26th July)
:
Mentors:
Depends on:
Blocks: 394167
  Show dependency treegraph
 
Reported: 2012-12-13 01:58 PST by Mark Banner (:standard8) (afk until 26th July)
Modified: 2012-12-14 09:13 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (10.80 KB, patch)
2012-12-13 03:31 PST, Mark Banner (:standard8) (afk until 26th July)
neil: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) (afk until 26th July) 2012-12-13 01:58:40 PST
The following functions/methods are unused but use nsISupportsArray, we should just drop them:

- nsIMsgFolder::getExpansionArray
- nsMsgRDFDataSource::GetTransactionManager

I'm also replacing the nsISupportsArray instances for:

- nsMsgResultElement::m_valueList

and in these files where nsISupportsArray has been used for window.open arguments:

- nsMessengerBootstrap.cpp
- nsMessengerWinIntegration.cpp
- nsMsgProgress.cpp
Comment 1 Mark Banner (:standard8) (afk until 26th July) 2012-12-13 03:31:26 PST
Created attachment 691753 [details] [diff] [review]
The fix

I guess it helps to attach the patch and request review ;-)
Comment 2 Mark Banner (:standard8) (afk until 26th July) 2012-12-13 14:04:54 PST
https://hg.mozilla.org/comm-central/rev/bdf948453896
Comment 3 Philip Chee 2012-12-14 00:34:36 PST
> - nsMessengerWinIntegration.cpp
I had to add:
#include "nsIMutableArray.h"
to this file to get it to compile.
Comment 4 neil@parkwaycc.co.uk 2012-12-14 09:13:21 PST
I compiled on Linux, so I didn't catch that :-(

Note You need to log in before you can comment on or make changes to this bug.