Closed
Bug 821245
Opened 12 years ago
Closed 12 years ago
Remove /data/local/tmp directory will cause adb server on some phone to crash
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timdream, Assigned: timdream)
Details
(Whiteboard: QARegressExclude)
Attachments
(1 file)
|
679 bytes,
patch
|
vingtetun
:
review+
vingtetun
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
We found that on phones specific to some venders, removing /data/local/tmp will cause adb to loose connection.
I've modified |make purge| not to do that, but use a for loop to delete files other than tmp.
Should be a trivial change to the Makefile but critical to a unannounced project. Vivien, please approve this change, thanks.
Attachment #691744 -
Flags: review?(21)
Attachment #691744 -
Flags: approval-gaia-master?(21)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 691744 [details] [diff] [review]
Makefile patch
Review of attachment 691744 [details] [diff] [review]:
-----------------------------------------------------------------
::: Makefile
@@ +605,5 @@
> purge:
> $(ADB) shell stop b2g
> + @(for FILE in `$(ADB) shell ls $(MSYS_FIX)/data/local | tr -d '\r'`; \
> + do \
> + echo $$FILE; \
nit: the indent seems a bit strange
Attachment #691744 -
Flags: review?(21)
Attachment #691744 -
Flags: review+
Attachment #691744 -
Flags: approval-gaia-master?(21)
Attachment #691744 -
Flags: approval-gaia-master+
|
Assignee | |
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•