Closed Bug 821328 Opened 10 years ago Closed 10 years ago

Calling openUILinkIn from PlacesUIUtils.jsm _openNodeIn fails when where = "save"

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: tabmix.onemen, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(1 file)

1. set browser.altClickSave to true
2. Alt+click (enter) from bookmarks sidebar or library

result after bug 814264 landed:
"openUILink/openLinkIn was called with "where == 'save' but without initiatingDoc.  See bug 814264."

result before bug 814264 landed:
saveURL not defined
it's likely this code needs to be updated to properly pass the document.
Component: General → Bookmarks & History
Assignee: nobody → mak77
I'm taking this just to have it on the radar, if you want to make a patch feel free to take it.
so, this was already not working (since it's trying to use saveURL but the sidebar doesn't have contentAreaUtils) and it is still not working (now throws), likely not worth to track, considered it's also enabled through a non-default pref.
the original bug about "saveURL not defined" is bug 451658
Attached patch patch v1.0Splinter Review
and I think this is the proper patch to fix both bugs, just ignore alt. alt+click was intended for content links, not for chrome.
Attachment #691961 - Flags: review?(dao)
Blocks: 451658
Attachment #691961 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/f0b590fbfd9f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.