Closed
Bug 821328
Opened 12 years ago
Closed 12 years ago
Calling openUILinkIn from PlacesUIUtils.jsm _openNodeIn fails when where = "save"
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: tabmix.onemen, Assigned: mak)
References
Details
(Keywords: regression)
Attachments
(1 file)
735 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
1. set browser.altClickSave to true
2. Alt+click (enter) from bookmarks sidebar or library
result after bug 814264 landed:
"openUILink/openLinkIn was called with "where == 'save' but without initiatingDoc. See bug 814264."
result before bug 814264 landed:
saveURL not defined
Assignee | ||
Comment 1•12 years ago
|
||
it's likely this code needs to be updated to properly pass the document.
Assignee | ||
Updated•12 years ago
|
Component: General → Bookmarks & History
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mak77
Assignee | ||
Comment 2•12 years ago
|
||
I'm taking this just to have it on the radar, if you want to make a patch feel free to take it.
Updated•12 years ago
|
tracking-firefox18:
--- → ?
tracking-firefox19:
--- → ?
tracking-firefox20:
--- → ?
Keywords: regression
Assignee | ||
Comment 3•12 years ago
|
||
so, this was already not working (since it's trying to use saveURL but the sidebar doesn't have contentAreaUtils) and it is still not working (now throws), likely not worth to track, considered it's also enabled through a non-default pref.
Assignee | ||
Comment 4•12 years ago
|
||
the original bug about "saveURL not defined" is bug 451658
Updated•12 years ago
|
Assignee | ||
Comment 5•12 years ago
|
||
and I think this is the proper patch to fix both bugs, just ignore alt. alt+click was intended for content links, not for chrome.
Assignee | ||
Updated•12 years ago
|
Attachment #691961 -
Flags: review?(dao)
Updated•12 years ago
|
Attachment #691961 -
Flags: review?(dao) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•