821334 - Apps are resized without taking care of keyboard

Status: RESOLVED DUPLICATE of bug 821678

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alexandre Poirot [:ochameau]]

In various cases, only when the keyboard is displayed, apps are being resize with a too big height. So that part of its content disappear behind the keyboard.

Here is at least two scenarios:
- after receiving a call
- when receiving an sms while being in sms app

That's because setAppSize method of the window manager is called in many cases and doesn't take keyboard height into account:
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L172

Test case:
- Open sms app
- Open a thread
- focus input message, the keyboard is displayed
- receive a call, ignore it -or- receive a sms

Current:
  The input disappear behind the keyboard.

Expected:
  The input stay in the same position, the app height isn't modified.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 7002

Sorry alive, but I'm suggesting to still patch setAppSize. As it really is buggy even outside of the sms case.

Please see first bug comment to see broken usages.

I've added the modification I suggested to tim this morning on irc: call setAppSize only when needed on open-app event. We only need to call it after appendFrame.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 691915 [details]
Pull request 7002

I don't think the case you said should be fixed. The attention screen grabs the focus from foreground app, that's why keyboard disappears. That's what keyboard being designed to, now.

OK I test manually and I think the problem should be: focus attention screen iframe when it shows to let the keyboard disappears. Now keyboard is there when attention screen comes. Annoying should be fixed. But not this way...

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Please request again after describe more clearly and nominate for blocking.