821366 - time picker could not set correct value to the input

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: screenshot for wrong time value.

STR
====

1. Go to calendar app.
2. click the "plus" icon to add a new event.
3. click the date input and use the new spinner style date picker, move the year forward to like 2035.
4. click the time picker and change the hour.

Expected: 
   The input could show the correct time set.

Actual:
   Sometimes it would show "NaN:00" or some unexpected value from the time picker.


Note: this is a regression caused by Bug 813138 and we already prepare a patch for this.

**Note for Triage**
This should be a blocker+, since time picker is one of the basic system component.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7000

Pointer to Github pull-request

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 691881 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7000

Dear Ian,

Could you please help review this change in value picker?
Thank you.

You may want to reference the pull request that caused this regression.
https://github.com/mozilla-b2g/gaia/pull/6963

Comment 3

[[e-mail], [e-mail]]

(In reply to Rudy Lu [:rudyl] from comment #0)
> Created attachment 691877 [details]
> screenshot for wrong time value.
> 
> STR
> ====
> 
> 1. Go to calendar app.
> 2. click the "plus" icon to add a new event.
> 3. click the date input and use the new spinner style date picker, move the
> year forward to like 2035.
> 4. click the time picker and change the hour.
Step 4. Should be "Click the time picker and click OK directly"

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 691881 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7000

It looks like a nit in naming variable.
I verify your patch and work for me.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, C3, P2 - regression

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Fixed with,
https://github.com/mozilla-b2g/gaia/pull/7000.

Comment 7

[:CSchmoeckel]

Verified that the time picker no longer displays an invalid value after setting a Calendar event for a date in the distant future.
Checked on 20130103070201 on 1/3/13