821383 - Don't bother with JSAPI magic in nsHTMLMediaElement::{G,S}etMozSrcObject

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 691886 [details] [diff] [review]
Patch v1

Looks ok to me, but check with roc that the "silently ignore other objects" behavior is not by design?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I actually want to extend this attribute so a Blob can be assigned too, and maybe other objects eventually. So, I think we should not do this.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2)
> I actually want to extend this attribute so a Blob can be assigned too, and
> maybe other objects eventually. So, I think we should not do this.

We'll be on webidl bindings long before this happens, so I think we should land this.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 691886 [details] [diff] [review]
Patch v1

Review of attachment 691886 [details] [diff] [review]:
-----------------------------------------------------------------

Fair enough.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/103a7bbcf074