821389 - Root jsapi-tests/testLooselyEqual.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

The JSAPI test infrastructure is awful for our exact rooting stuff.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Horrific rooting for testLooselyEqual values

Please tell me there's a better way.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 691889 [details] [diff] [review]
Horrific rooting for testLooselyEqual values

Review of attachment 691889 [details] [diff] [review]:
-----------------------------------------------------------------

Lets try Jason's idea first.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Not so horrific rooting for testLooselyEqual values

Take 2, with jorendorff's suggestion.

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 691898 [details] [diff] [review]
Not so horrific rooting for testLooselyEqual values

Review of attachment 691898 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 5

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e3559bd8606f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e3559bd8606f