Closed
Bug 821459
Opened 13 years ago
Closed 13 years ago
keyboard overwrites don't work because of typo
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(blocking-basecamp:-)
VERIFIED
FIXED
| blocking-basecamp | - |
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file, 1 obsolete file)
|
528 bytes,
patch
|
kaze
:
review+
vingtetun
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
Just a silly key name title. I tested this on a desktop build:
https://github.com/mozilla-b2g/gaia/pull/7006
|
Assignee | |
Comment 1•13 years ago
|
||
To make this easier to review, here's the code that interprets this, showing it looking for "textLayoutOverwrites": https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/keyboard.js#L628
|
|
Assignee | |
Comment 2•13 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed:
Risk to taking this patch (and alternatives if risky):
Attachment #693358 -
Flags: review?(kaze)
|
|
Assignee | |
Comment 3•13 years ago
|
||
This fixes other keyboards too. Good catch!
Attachment #693358 -
Attachment is obsolete: true
Attachment #693358 -
Flags: review?(kaze)
Attachment #693366 -
Flags: review?(kaze)
|
|
Assignee | |
Updated•13 years ago
|
Summary: dvorak keyboard overwrites don't work because of typo → keyboard overwrites don't work because of typo
|
||
Updated•13 years ago
|
Attachment #693366 -
Flags: review?(kaze) → review+
|
|
||
Updated•13 years ago
|
blocking-basecamp: --- → ?
Attachment #693366 -
Flags: approval-gaia-master+
blocking-basecamp: ? → -
|
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•