Closed
Bug 821484
Opened 12 years ago
Closed 12 years ago
ASSERTION: mDone shouldn't have been set to true already!: '!mDone', file dom/base/DOMRequest.cpp, line 113
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: gwagner)
Details
Attachments
(1 file, 1 obsolete file)
5.07 KB,
patch
|
sicking
:
review+
jst
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
Seen during B2G starup on otoro with debug build
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → anygregor
Attachment #692043 -
Flags: review?(jonas)
Assignee | ||
Comment 2•12 years ago
|
||
wrong patch
Attachment #692043 -
Attachment is obsolete: true
Attachment #692043 -
Flags: review?(jonas)
Attachment #692065 -
Flags: review?(jonas)
Comment on attachment 692065 [details] [diff] [review] patch Review of attachment 692065 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/settings/SettingsManager.js @@ +74,5 @@ > req = store.put({settingName: key, settingValue: obj}); > } > > + req.onsuccess = function() { > + if (key === keys[keys.length-1] && !req.error) { request.error And I think it'd be clearer to do: if (i === keys.length-1) { req.onsuccess = function() { if (!request.error) { Services.DOMRequest.fireSuccess(...) } } } @@ +84,4 @@ > }; > > req.onerror = function() { > + if (!req.error) { request.error
Attachment #692065 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04b23376b9c3
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04b23376b9c3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Assignee | ||
Updated•11 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Comment 6•11 years ago
|
||
I think we should take this. I already get into complex merge problems without this patch that are more likely to introduce new bugs.
Comment 7•11 years ago
|
||
Comment on attachment 692065 [details] [diff] [review] patch Feel free to land this on the b2g18 branch, but we won't block on this.
Attachment #692065 -
Flags: approval-mozilla-b2g18+
Updated•11 years ago
|
blocking-basecamp: ? → -
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/2548ba1e340b
status-b2g18:
--- → fixed
Updated•11 years ago
|
status-firefox19:
--- → wontfix
status-firefox20:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•