821484 - ASSERTION: mDone shouldn't have been set to true already!: '!mDone', file dom/base/DOMRequest.cpp, line 113

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gregor Wagner [:gwagner]]

Seen during B2G starup on otoro with debug build

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

wrong patch

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 692065 [details] [diff] [review]
patch

Review of attachment 692065 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsManager.js
@@ +74,5 @@
>                req = store.put({settingName: key, settingValue: obj});
>              }
>  
> +            req.onsuccess = function() {
> +              if (key === keys[keys.length-1] && !req.error) {

request.error

And I think it'd be clearer to do:

if (i === keys.length-1) {
  req.onsuccess = function() {
    if (!request.error) {
      Services.DOMRequest.fireSuccess(...)
    }
  }
}

@@ +84,4 @@
>              };
>  
>              req.onerror = function() {
> +              if (!req.error) {

request.error

Comment 4

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04b23376b9c3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/04b23376b9c3

Comment 6

[Gregor Wagner [:gwagner]]

I think we should take this. I already get into complex merge problems without this patch that are more likely to introduce new bugs.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 692065 [details] [diff] [review]
patch

Feel free to land this on the b2g18 branch, but we won't block on this.

Comment 8

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2548ba1e340b