nptest_droid.cpp:85: warning: 'void pluginDrawWindow(InstanceData*, void*)' defined but not used

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla20
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

I just tried to mark dom/plugins/test/testplugin/ as FAIL_ON_WARNINGS, but it busted android because there's a build warning in nptest_droid.cpp:
{
dom/plugins/test/testplugin/nptest_droid.cpp:85: error: 'void pluginDrawWindow(InstanceData*, void*)' defined but not used
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=17921945&tree=Mozilla-Inbound

Filing this bug on that warning/error.
This function has been unused ever since nptest_droid.cpp was added to the tree in
 https://hg.mozilla.org/mozilla-central/rev/4f2ef4057c63

From searching for the function-name, it looks like we've got an analogous static function in nptest_qt.cpp and nptest_gtk2.cpp, which we use as a helper for other functions.  nptest_droid doesn't use it, though, so looks like we can drop it from that file.
Blocks: 577347
Posted patch fixSplinter Review
Attachment #692087 - Flags: review?(blassey.bugs)
Attachment #692087 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/473bd0eee23b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.