821589 - mozApps.installPackage doesn't have any automated tests at the DOM level

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #772365 +++

I wrote some automated tests for the signature verification code in PSM, but we don't have any tests at the DOM layer or the GAIA layer. We should build some mochitests and whatnot. For example, we should test that unsigned privileged apps cannot be installed and that privileged signed apps can be installed and that certified apps can never be installed whether they are signed or not.

Comment 2

[Jason Smith [:jsmith]]

To get this automation off the ground, we're going to want to put the dependencies on the UI dependent on a preference that SpecialPowers can flip to disable the UI. That's probably the first step - as that will remove the dependency on mochitest chrome and probably make it easier to write this automation targeting the DOM-specific pieces we're looking to analyze.

Comment 3

[Andreas Gal :gal]

Definitely something we want to fix, but I wouldn't hold the product over it.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 0: Add SpecialPowers.autoConfirmAppInstall for packaged apps

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Tests base. WIP

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Tests base. WIP

144 INFO TEST-START | Shutdown
145 INFO Passed: 134
146 INFO Failed: 0
147 INFO Todo:   5
148 INFO SimpleTest FINISHED

IMO this patch could land as soon as Bug 826058 lands. Until then, I'll be adding more tests if possible.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Tests. WIP

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Tests. WIP

More tests

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://tbpl.mozilla.org/?tree=Try&rev=9caa6c7afd1e

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part1: Tests

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

New try run https://tbpl.mozilla.org/?tree=Try&rev=d395773687d4

Comment 12

[[:fabrice] Fabrice Desré]

defineLazyServiceGetter is failing in Cc[@mozilla.org/parentprocessmessagemanager;1].getService(Ci.nsIMessageBroadcaster) according to the instrumented try push at:
https://tbpl.mozilla.org/?tree=Try&rev=8487cc30cfc9

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Try build https://tbpl.mozilla.org/?tree=Try&rev=8620ce064a12 including the fix for Bug 873134

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Tests

Comment 15

[Jason Smith [:jsmith]]

Comment on attachment 751002 [details] [diff] [review]
Part 1: Tests

Review of attachment 751002 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/tests/Makefile.in
@@ +21,3 @@
>    $(NULL)
>  
> +ifdef MOZ_B2G

We have packaged apps enabled on Android as well. Do these tests run successfully on FxAndroid if you allow them to run?

Comment 16

[[:fabrice] Fabrice Desré]

Comment on attachment 751002 [details] [diff] [review]
Part 1: Tests

Review of attachment 751002 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, woohoo!

Jason, can we check that this runs also on Android in a followup? I'd like this to land so badly...

::: dom/apps/tests/test_packaged_app_install.html
@@ +303,5 @@
> +                          "?getManifest=true" +
> +                          "&wrongPackagePath=true";
> +    checkAppInstallError(miniManifestURL, "INVALID_MANIFEST");
> +  },
> +  function() {    

nit: trailing whitespace

@@ +327,5 @@
> +  },
> +  function() {
> +    // Test mini-manifest dev name is different from the webapp manifest dev
> +    // name.
> +    ok (true, "== TEST == Mini-manifest dev name is different from manifest " + 

here also

Comment 17

[Jason Smith [:jsmith]]

Yes. We can do that in a followup. I'll file a bug to get the tests running on FxAndroid.

Comment 18

[Jason Smith [:jsmith]]

Filed bug 873567 to get these tests running on FxAndroid.

Comment 19

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf32db974ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc47c6690f68

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ecf32db974ef
https://hg.mozilla.org/mozilla-central/rev/bc47c6690f68