821615 - B2G 3G: Unable to deactivate data call on emulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Shian-Yow Wu [:swu]]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=821578#c1
When this happens, it's not able to enable/disable data call anymore except restarting B2G.

IMHO, even we got error REQUEST_DEACTIVATE_DATA_CALL request from emulator or vendor RIL, we should deactivate the data call status on Gecko side.

Comment 1

[Jessica Jong [:jessica] (inactive)]

I was just implementing the data deactivation part for the emulator.
Can I take this bug so that you can give me some feedback about the work?

Thanks.

Comment 2

[Shian-Yow Wu [:swu]]

Jessica,

Yes, please take it.  It's good you can help on this bug.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Attachment: part 1 - PR to platform_hardware_ril

Comment 4

[Jessica Jong [:jessica] (inactive)]

Attachment: part 2 - PR to platform_external_qemu

Comment 5

[Jessica Jong [:jessica] (inactive)]

The idea is to set or clear modem->data_contexts according to the ril request (activation/deactivation).
Not sure who should I ask for comment/review...?

Thanks!

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Merged on GitHub:
https://github.com/mozilla-b2g/platform_external_qemu/commit/1f47539062742ddcd5767b4df0a853f1c1add7ac
https://github.com/mozilla-b2g/platform_hardware_ril/commit/0379d009d3d48b868e69adc5e523e227300ab97d