Support for specifying promptWaitTime for updates

RESOLVED FIXED

Status

Release Engineering
Release Automation: Other
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 813322 added a new parameter to control how long the updater waits before showing a dialog to user asking them to restart. Bug 816408 is about adding support to AUSv2. This bug is about making sure we support it in the releases automation.

From a quick discussion with bhearsum this might turn out to be a no-op. We're proposing we handle this like 'actions  silent' for suppressing What's New pages after updates, in that the patcher config is modified by a release engineer if desired. If we use the same parameter name in patcher config, snippets and AUS we might not need any changes in the snippet generator due to
 https://github.com/mozilla/build-tools/blob/master/lib/python/release/updates/snippets.py#L66
(Assignee)

Updated

6 years ago
Assignee: nobody → nthomas
(Assignee)

Comment 1

6 years ago
Created attachment 693810 [details] [diff] [review]
[tools] Generalise support for schema 2 attributes

This adjusts parseCurrentUpdate to support all the optional attributes, and adds promptWaitTime to the list of them.
Attachment #693810 - Flags: review?(bhearsum)
(Assignee)

Comment 2

6 years ago
I reran the update generation for Firefox 17.0.1 with this and it didn't regress anything. Adding a 
  promptWaitTime   999
to the <current-update> block appended 
  promptWaitTime=999
to every snippet generated.
Comment on attachment 693810 [details] [diff] [review]
[tools] Generalise support for schema 2 attributes

Review of attachment 693810 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like it still passes all tests too, looks good!
Attachment #693810 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 693810 [details] [diff] [review]
[tools] Generalise support for schema 2 attributes

Squashed a couple of trailing spaces on commit:
http://hg.mozilla.org/build/tools/rev/565761bac81f
Attachment #693810 - Flags: checked-in+
(Assignee)

Comment 5

6 years ago
Basic support is in place with the patch here. For build requests where RelMan ask for a non-default prompt time add a line like
   promptWaitTime  <time in seconds>
to the <current-update> block of the the appropriate patcher config.

Bug 823841 for the convenience of being able to specify the value in the release kickoff app.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.