821639 - java.lang.IllegalArgumentException: favicon height must be > 0 at android.graphics.Bitmap.checkWidthHeight(Bitmap.java)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Scoobidiver (away)]

It has been hit by two users in Aurora. Here is a crash report: bp-20162591-9608-4cd2-bd84-a5b9c2121211.

java.lang.IllegalArgumentException: height must be > 0
	at android.graphics.Bitmap.checkWidthHeight(Bitmap.java:243)
	at android.graphics.Bitmap.createBitmap(Bitmap.java:496)
	at android.graphics.Bitmap.createScaledBitmap(Bitmap.java:437)
	at org.mozilla.gecko.AwesomeBarTab.updateFavicon(AwesomeBarTab.java:114)
	at org.mozilla.gecko.AllPagesTab.displayFavicon(AllPagesTab.java:801)
	at org.mozilla.gecko.AllPagesTab.access$1000(AllPagesTab.java:61)
	at org.mozilla.gecko.AllPagesTab$AwesomeBarCursorAdapter.getView(AllPagesTab.java:431)
	at android.widget.AbsListView.obtainView(AbsListView.java:2022)
	at android.widget.ListView.makeAndAddView(ListView.java:1815)
	at android.widget.ListView.fillDown(ListView.java:687)
	at android.widget.ListView.fillSpecific(ListView.java:1363)
	at android.widget.ListView.fillSpecific(ListView.java:1342)
	at android.widget.ListView.layoutChildren(ListView.java:1646)
	at android.widget.AbsListView.onLayout(AbsListView.java:1873)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1666)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1524)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1429)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.support.v4.view.ViewPager.onLayout(ViewPager.java:1388)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1666)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1524)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1429)
	at org.mozilla.gecko.AwesomeBarTabs$Background.onLayout(AwesomeBarTabs.java:324)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:443)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1666)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1524)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1429)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:443)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1666)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1524)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1429)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:443)
	at android.view.View.layout(View.java:11444)
	at android.view.ViewGroup.layout(ViewGroup.java:4331)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1493)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2446)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4448)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:823)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:590)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A+height+must+be+%3E+0+at+android.graphics.Bitmap.checkWidthHeight%28Bitmap.java%29

Comment 1

[Chris Peterson [:cpeterson]]

wesj, this crash looks like we have a favicon with a height of 0 pixels?!

Comment 2

[Chris Kitching [:ckitching]]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> wesj, this crash looks like we have a favicon with a height of 0 pixels?!

At a guess - couldn't this be caused by downloading corrupt/incomplete data from the server when getting the Favicon. Attempting to decode that is liable not to be pretty. Seems that an appropriately-placed sanity check might make this go away. (If it hasn't already)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.