821717 - Table headers in the "Saved Searches" and "Email Prefs" panels are wrongly right-aligned

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

In the "Saved Searches" pref panel, the table headers should be centered, not right-aligned. This is a regression due to bug 547311.

Comment 1

[Christopher Trom]

This problem also occurs in the "Email Preferences" pref panel.

This could be fixed by adding a class to these elements. I don't see how any other CSS selection method would fix this without breaking something else.

Comment 2

[Christopher Trom]

Attachment: Patch.V1

This patch adds a "text-align: center;" rule and removes align="center" where the rule is applied.

Comment 3

[Frédéric Buclin]

Comment on attachment 712062 [details] [diff] [review]
Patch.V1

=== modified file 'skins/standard/global.css'

 }
-
+table#email_prefs th,

Keep the empty line before this line. This is more readable.



>=== modified file 'template/en/default/account/prefs/email.html.tmpl'

>-    <td colspan="[% num_columns FILTER html %]" align="center" width="50%">
>+    <td colspan="[% num_columns FILTER html %]" width="50%">

There is no reason to remove align="center" from here. It's not a <th>.



>=== modified file 'template/en/default/account/prefs/saved-searches.html.tmpl'

>-  <table border="1" cellpadding="3">  
>+  <table id="saved_search_prefs" border="1" cellpadding="3">  

You must also fix the 2nd table, about shared queries.

Comment 4

[Christopher Trom]

Attachment: Patch.V2

Comment 5

[Frédéric Buclin]

Comment on attachment 714869 [details] [diff] [review]
Patch.V2

You didn't fix the 3rd part of my previous review, about the 2nd table in the Saved Search tab.

Comment 6

[Christopher Trom]

Attachment: Patch.V3

Sorry about that.

Comment 7

[Frédéric Buclin]

Comment on attachment 714918 [details] [diff] [review]
Patch.V3

It's illegal to use twice the same ID in a page (else document.getElementById() would be unable to retrive the right HTML object).

Comment 8

[Christopher Trom]

Attachment: Patch.V4

Comment 9

[Frédéric Buclin]

Comment on attachment 714953 [details] [diff] [review]
Patch.V4

>=== modified file 'template/en/default/account/prefs/saved-searches.html.tmpl'

>+  <table id="shared_search_prefs" border="1" cellpadding="3">  

>+  <table id="saved_search_prefs" border="1" cellpadding="3">  

Both names have been reversed. I will fix that on checkin. Thanks for the patch! r=LpSolit

Comment 10

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified skins/standard/global.css
modified template/en/default/account/prefs/email.html.tmpl
modified template/en/default/account/prefs/saved-searches.html.tmpl
Committed revision 8594.