Translation signals

RESOLVED FIXED in 2013-04-04

Status

P4
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: andy+bugzilla, Assigned: andy+bugzilla)

Tracking

2013-04-04
x86
Mac OS X
Points:
---

Details

(Whiteboard: p=3)

(Assignee)

Description

6 years ago
So for each translated field on each *object*, translations creates a signal when its loaded. It then never deletes that signal. It tries to if the object gets saved (which is questionable) but the delete fails.

That means that by the end of ~1,900 unit tests in marketplace, there's been 490,000 signals called and the end tests are going much slower.

This also is in evidence if you edit and addon multiple times through runserver. The number of registered signals keep growing.
(Assignee)

Updated

6 years ago
Assignee: nobody → amckay
(Assignee)

Comment 1

6 years ago
https://github.com/andymckay/zamboni/commit/e2a72b

Depressed, introduced 2 failures and saved 2,000 signal calls. Which saved about 4% of the test speed.
(Assignee)

Updated

6 years ago
Priority: P1 → P4
Target Milestone: --- → 2013-03-14
(Assignee)

Updated

6 years ago
Whiteboard: p=3
(Assignee)

Comment 2

6 years ago
Tests are green pull request ready, but lets merge it after I'm back from PTO.
Target Milestone: 2013-03-14 → 2013-03-28
Target Milestone: 2013-03-28 → 2013-04-04
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla/zamboni/commit/22ded2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.