Closed Bug 821773 Opened 12 years ago Closed 11 years ago

Translation signals

Categories

(Marketplace Graveyard :: Code Quality, defect, P4)

Product:
Marketplace Graveyard
Component:
Code Quality
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-04-04

People

(Reporter: andy+bugzilla, Assigned: andy+bugzilla)

Details

(Whiteboard: p=3) 

So for each translated field on each *object*, translations creates a signal when its loaded. It then never deletes that signal. It tries to if the object gets saved (which is questionable) but the delete fails.

That means that by the end of ~1,900 unit tests in marketplace, there's been 490,000 signals called and the end tests are going much slower.

This also is in evidence if you edit and addon multiple times through runserver. The number of registered signals keep growing.
Assignee: nobody → amckay
https://github.com/andymckay/zamboni/commit/e2a72b

Depressed, introduced 2 failures and saved 2,000 signal calls. Which saved about 4% of the test speed.
Priority: P1 → P4
Target Milestone: --- → 2013-03-14
Whiteboard: p=3
Tests are green pull request ready, but lets merge it after I'm back from PTO.
Target Milestone: 2013-03-14 → 2013-03-28
Target Milestone: 2013-03-28 → 2013-04-04
https://github.com/mozilla/zamboni/commit/22ded2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.