Closed Bug 821843 Opened 7 years ago Closed 7 years ago

nsPluginHost.cpp:956:8: error: variable ‘isJava’ set but not used [-Werror=unused-but-set-variable]

Categories

(Core :: Plug-ins, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When building today w/ g++ 4.7 and --enable-warnings-as-errors:
{
dom/plugins/base/nsPluginHost.cpp:956:8: error: variable ‘isJava’ set but not used [-Werror=unused-but-set-variable]
}

Looks like bug 767633 removed the last use of "isJava", so we should just drop that variable altogether.
Attached patch fixSplinter Review
Attachment #692417 - Flags: review?(joshmoz)
(In reply to Daniel Holbert [:dholbert] from comment #0)
> Looks like bug 767633 removed the last use of "isJava", so we should just
> drop that variable altogether.

For reference, that removal was:
  https://hg.mozilla.org/mozilla-central/rev/11341616d7cb#l1.120
Comment on attachment 692417 [details] [diff] [review]
fix

(actually, not sure if josh is around today, so I'm adding johns as an alternate reviewer, in the interests of getting this fixed ASAP so others don't get broken builds after pulling.)
Attachment #692417 - Flags: review?(jschoenick)
Comment on attachment 692417 [details] [diff] [review]
fix

Review of attachment 692417 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #692417 - Flags: review?(jschoenick)
Attachment #692417 - Flags: review?(joshmoz)
Attachment #692417 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e7b35e1e28d4
Assignee: nobody → dholbert
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.