821843 - nsPluginHost.cpp:956:8: error: variable ‘isJava’ set but not used [-Werror=unused-but-set-variable]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Daniel Holbert [:dholbert]]

When building today w/ g++ 4.7 and --enable-warnings-as-errors:
{
dom/plugins/base/nsPluginHost.cpp:956:8: error: variable ‘isJava’ set but not used [-Werror=unused-but-set-variable]
}

Looks like bug 767633 removed the last use of "isJava", so we should just drop that variable altogether.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> Looks like bug 767633 removed the last use of "isJava", so we should just
> drop that variable altogether.

For reference, that removal was:
  https://hg.mozilla.org/mozilla-central/rev/11341616d7cb#l1.120

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 692417 [details] [diff] [review]
fix

(actually, not sure if josh is around today, so I'm adding johns as an alternate reviewer, in the interests of getting this fixed ASAP so others don't get broken builds after pulling.)

Comment 4

[John Schoenick [:johns]]

Comment on attachment 692417 [details] [diff] [review]
fix

Review of attachment 692417 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/mozilla-central/rev/e7b35e1e28d4