Android build broken in DataChannel code

RESOLVED FIXED in mozilla20

Status

()

Core
WebRTC: Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

Trunk
mozilla20
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 692421 [details] [diff] [review]
Re-apply DeMorgan's law to preprocessor conditions

Here's the error:

/Users/dmose/r/inbound/src/netwerk/sctp/datachannel/DataChannel.cpp: In member function 'virtual nsresult mozilla::DataChannelConnectRunnable::Run()':
/Users/dmose/r/inbound/src/netwerk/sctp/datachannel/DataChannel.cpp:397: error: 'struct sockaddr_conn' has no member named 'sconn_len'

In the directory  /Users/dmose/r/inbound/objdir-droid/netwerk/sctp/datachannel
The following command failed to execute properly:

I think there was a race in the creation of the cleanup patch such that when the cleanup patch landed, it regressed a fix for this problem which had landed previously.  Patch for bustage attached.
Attachment #692421 - Flags: review?(rjesup)
(Assignee)

Comment 1

5 years ago
Try server build in progress:

 https://tbpl.mozilla.org/?tree=Try&rev=f73d6ea2a425

Updated

5 years ago
Attachment #692421 - Flags: review?(rjesup) → review+
(Assignee)

Comment 2

5 years ago
Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb6f5a9bcd27

in-testsuite-, as this is build bustage fixing, so the compiler acts as the test suite.
Flags: in-testsuite-
(Assignee)

Updated

5 years ago
OS: All → Android
Hardware: All → ARM
(In reply to Dan Mosedale (:dmose) from comment #2)
> Pushed to inbound:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/bb6f5a9bcd27
> 
> in-testsuite-, as this is build bustage fixing, so the compiler acts as the
> test suite.

This was mis-posted in bug 821249, because the wrong bug number was in the commit message.

https://hg.mozilla.org/mozilla-central/rev/bb6f5a9bcd27
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.