821852 - [Activities] [SMS & Contact] Creating a contact from SMS App is not working properly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[David Walsh :davidwalsh]

After receiving a text from a new person, I tapped their name to create a new contact.  After creating the contact, I was taken to the home screen.  I should have been taken back to the SMS app.

Comment 1

[Borja Salguero [:borjasalguero]]

Probably there is some issue with activities. Tested with today's build and the bug is still there... It should be bb+ because the interaction between SMS & Contact App is not working

Comment 2

[Faramarz Rashed]

:scravag, can you find someone to work on this?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7097

Patch v1:
Make disposition of new contact activity inline.
Disposition:window is not guaranteed to returned to activity caller when it ends.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 694208 [details]
https://github.com/mozilla-b2g/gaia/pull/7097

r=me thanks.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/7304395ff0cdfe4de6eb4dd8efc53e89ddca1ed2

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

If people could understand me in bug 808634 this will be already fixed 1 months ago...

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #7)
> If people could understand me in bug 808634 this will be already fixed 1
> months ago...

Hush! You must threaten them with how serious that bug was :)
BTW, one month ago, the incorrect reopen-self callback still lived in apps, so the bug was not that serious then.

Comment 9

[cbarker]

Verified Fixed in Unagi Build 12021231070201