821904 - Fix build warnings in media/mtransport/third_party/nrappkit/src/util/libekr

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Networking, defect)

Description

[Catalin Iordache]

Attachment: p3v1.patch

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121129151900

Steps to reproduce:

Fixed build warnings in r_assoc.c , r_list.c , r_time.c

Comment 1

[Matthias Versen [:Matti]]

These is third party code and this probably have to be fixed upstream.

Comment 2

[Catalin Iordache]

is there any chances to get a review+ for this bug?

Comment 3

[Eric Rescorla (:ekr)]

Comment on attachment 692473 [details] [diff] [review]
p3v1.patch

Review of attachment 692473 [details] [diff] [review]:
-----------------------------------------------------------------

The construct you are changing:
 
if (r = foo()) {


}

is used all over the upstream code. I'm not sure why you're not seeing these warnings
throughout your compile. Regardless, we have opted to suppress the parentheses
warnings for these files rather than do a mass change. See:

https://hg.mozilla.org/mozilla-central/file/bb2f453b7c0f/media/mtransport/third_party/nrappkit/nrappkit.gyp#l154

If you are still seeing these warnings, it is presumably because the suppression
is not working for your platform.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Please report the OS/compiler and version numbers, plus the actual output showing the problem.

Comment 5

[Catalin Iordache]

This were my build warnings:
media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:222:2 [-Wparentheses] suggest parentheses around assignment used as truth value 
media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:273:5 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:295:5 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:348:5 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:393:7 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_list.c:161:5 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_list.c:169:9 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_time.c:201:5 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_time.c:204:13 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_time.c:227:5 [-Wparentheses] suggest parentheses around assignment used as truth value
media/mtransport/third_party/nrappkit/src/util/libekr/r_time.c:230:13 [-Wparentheses] suggest parentheses around assignment used as truth value

Comment 6

[Catalin Iordache]

I tried to resolved them, building the files with make -C ./obj-[..]/rest of path. I'm using Ubuntu 12.10 3.5.0-19-generic .

I hope this is what you asked me.

Comment 7

[Catalin Iordache]

This is one of my first bugs for mozilla code base. I just wanted to resolve something simple for start.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Please also report the compiler and version used. Also, when posting a warning please include the commandline for the file as well (don't use -s in MOZ_MAKE_FLAGS)

Probably the compiler version is a newer version of GCC4.7 that added warnings or changes how they're suppressed.

Comment 9

[Catalin Iordache]

gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1)

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

I don't see these same errors when building on Fedora 17 with 4.7.2.