822100 - PDF plugin used while PDF document set to Preview

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Scoobidiver (away)]

STR:
1. Start 18.0b4
2. Set Adobe Acrobat plugin as your PDF viewer
3. Open a PDF document to check Adobe Acrobat plugin is used to open PDF documents
4. Close 18.0b4
5. Start Aurora with the same profile
6. Open a PDF document. Adobe Acrobat plugin is used to open PDF documents (Firefox respects your previous choice)
7. Go to Options > Application and scroll down to PDF document. Preview in Aurora is selected.

If you want to impose PDF Viewer, opening a PDF document should use PDF Viewer.
If you want to respect user's previous choice, the PDF document setting should stay unchange.

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: fix v1

The bug was a little unclear to me, so to re-iterate the problem:
When you take a profile from the current beta(18) then open it with aurora(19), pdf.js is not used for pdfs if you have a plugin installed that is setup to handle pdfs(such as acrobat).  If you restart aurora, pdf.js will work as expected.  I'm guessing something changed in the upgrade code that causes the plugins to be loaded hence why I have to notify the category manager to disable any plugins.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: pdf.js will not be active when users with acrobat upgrade to FF19 until they restart FF
Testing completed (on m-c, etc.): Sent to try and tested using Beta and Aurora to generate profiles.
Risk to taking this patch (and alternatives if risky): Not very risky, but this introduces some more first run code.
String or UUID changes made by this patch: none

Try Run:
https://tbpl.mozilla.org/?tree=Try&rev=f8a6b1e5be1f

Comment 2

[Alex Keybl [:akeybl]]

Comment on attachment 694881 [details] [diff] [review]
fix v1

Thanks for jumping on this before FF18b1 bdahl.

Comment 3

[Alex Keybl [:akeybl]]

FF19b1*

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d083267a188a

This was fixed on m-c by the pdf.js update in bug 824174.

Comment 5

[juan becerra [:juanb]]

The way I understand this is that the preference to use the built-in or an external PDF reader should be preserved when using the same profile when I go back and forth between Firefox 19 or 20.

That is what I observe in Firefox 19b3. When I setup Adobe Reader to be the default PDF reader (by going to the Applications section in the Options and selecting it from the list of default handlers), and I then use Firefox 20 and open a PDF, the document is opened with Adobe Reader. If I then flip that preference in Firefox 20 and go back to Firefox 19, the preference is preserved and the document is opened with the built-in reader.

Comment 6

[Scoobidiver (away)]

(In reply to juan becerra [:juanb] from comment #5)
> The way I understand this is that the preference to use the built-in or an
> external PDF reader should be preserved when using the same profile when I
> go back and forth between Firefox 19 or 20.
That was not the issue. It was between a version without built-in PDF Viewer and one with it, that is 18.0 and 19.0 Beta.

If I set a profile to use a PDF plugin in 18.0 and I open this profile with 19.0 Beta, PDF Viewer is used to open any PDF files and also set in the Application panel.

Comment 7

[Alex Keybl [:akeybl]]

Sounds like the preference in "Options > Applications" is being properly honored now. Thanks for testing all.

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

Marking VERIFIED based on comment #5 and no other affected branches.