822133 - Personas/lightweight themes not applied/broken

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android 20121216, Android 4.1.2 (stock), Google Nexus S

Starting with build 20121215, installed Personas are not applied anymore (I have https://addons.mozilla.org/firefox/addon/the-wind-blows/ installed).

Comment 1

[Aaron Train [:aaronmt]]

'Try it on' and 'Keep it' do not apply any theme.

Comment 2

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromdate=2012-12-15&todate=2012-12-16

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This is the correct null check.
(Sriram is not a good reviewer.. again!)

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/167cface3edc

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/167cface3edc

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 693016 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 820868.
User impact if declined: No persona will be seen. Everything will be blocked.
Testing completed (on m-c, etc.): Landed yesterday.
Risk to taking this patch (and alternatives if risky): None. A proper check is added now. (One character change).
String or UUID changes made by this patch: None.

Comment 7

[Ioana Chiorean]

Firefox 20.0a1 (2012-11-18)
Device: Galaxy Nexus
OS: Android 4.1.1

Personas (lightweight themes) can be applied now.  Marking bug as VERIFIED FIXED

Comment 8

[Ioana Chiorean]

(In reply to Ioana Chiorean from comment #7)
> Firefox 20.0a1 (2012-11-18)
> Device: Galaxy Nexus
> OS: Android 4.1.1
> 
> Personas (lightweight themes) can be applied now.  Marking bug as VERIFIED
> FIXED

It was Firefox 20.0a1 (2012-11-19)

Comment 9

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3adf6d8c5f6d

Comment 10

[Ioana Chiorean]

Firefox 19 Beta 1 (2013-01-08)
Device: Galaxy Nexus
OS:Android 4.1.

This was push in beta channel also as Firefox 19 is currently in Beta. As the themes are applied correctly now  I will mark the flag for 19 accordingly as Verified..