82219 - Trunk crash [@ nsStringBundleService::getStringBundle] in mail

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P1)

Description

[Jay Patel [:jay]]

I'm not sure what component this falls under, but I have crashed a few times 
today in mail just scrolling/clicking next in my inbox.  Here is some talkback 
info:

Incident ID 30775633 
 Trigger Time 
                2001-05-22 13:14:46 
 Email Address 
                [e-mail] 
 User Comments 
                just opened up the mail app and was clicking down through my 
message in my inbox. i think i hit my last message and
                click the mouse one too many times and boom! 
 Build ID
                2001052111 
 Product ID
                Netscape6.50 
 Platform ID
                Win32 
 Stack Trace

nsStringBundleService::getStringBundle 
[d:\builds\seamonkey\mozilla\intl\strres\src\nsStringBundle.cpp, line 874] 
nsStringBundleService::CreateBundle 
[d:\builds\seamonkey\mozilla\intl\strres\src\nsStringBundle.cpp, line 940] 
signed.dll + 0x12e3 (0x04fb12e3) 
signed.dll + 0x114a (0x04fb114a) 
signed.dll + 0x121f (0x04fb121f) 
MimeMultipart_close_child 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemult.cpp, line 432] 
MimeMultipart_parse_line 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemult.cpp, line 160] 
convert_and_send_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 134] 
mime_LineBuffer [d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 
256] 
MimeObject_parse_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimeobj.cpp, line 256] 
MimeMessage_parse_line 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemsg.cpp, line 214] 
convert_and_send_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 134] 
mime_LineBuffer [d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 
256] 
MimeObject_parse_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimeobj.cpp, line 256] 
MimeMessage_parse_line 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemsg.cpp, line 131] 
nsInputStreamTee::Read 
[d:\builds\seamonkey\mozilla\xpcom\io\nsInputStreamTee.cpp, line 123] 
nsStreamConverter::OnDataAvailable 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\nsStreamConverter.cpp, line 890] 
nsDocumentOpenInfo::OnDataAvailable 
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 238] 
nsStreamListenerTee::OnDataAvailable 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerTee.cpp, line 57] 
nsOnDataAvailableEvent0::HandleEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line 
416] 
nsStreamListenerEvent0::HandlePLEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line 
107] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 524] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 
1072] 
USER32.dll + 0x2a64c (0x77e9a64c)

Comment 1

[Jay Patel [:jay]]

Adding crash, topcrash keywords and [@ nsStringBundleService::getStringBundle] 
to summary.  This crash is showing up in the Talkback topcrash report.

Comment 2

[scottputterman]

There are a bunch of talkback reports for this.  Some of them mention reading a
signed message.  I don't know if that helps.  Moving to 0.9.1

Comment 3

[scottputterman]

Jay since this happened to you, do you have any particular message that this
occurs on?

Comment 4

[Jay Patel [:jay]]

i'm not sure which message it crashed at since i was just quickly going down the 
list...but it might have been jj's email on 5/22 at 11:54am.  cathleen also 
mentioned she crashed after clicking on jj's message from 5/18:

Trigger Time 
                2001-05-18 13:32:59 
 Email Address 
                [e-mail] 

 User Comments 
                crash on reading signed email. clicked on email sent by JJ 
regarding tree status on 5/18, 1:28pm 
 Build ID
                2001051812 
 Platform ID
                Win32 
 Stack Trace

nsStringBundleService::getStringBundle 
[d:\builds\seamonkey\mozilla\intl\strres\src\nsStringBundle.cpp, line 874] 
nsStringBundleService::CreateBundle 
[d:\builds\seamonkey\mozilla\intl\strres\src\nsStringBundle.cpp, line 940] 
signed.dll + 0x12e3 (0x609412e3) 
signed.dll + 0x114a (0x6094114a) 
signed.dll + 0x121f (0x6094121f) 
MimeMultipart_close_child 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemult.cpp, line 432] 
MimeMultipart_parse_line 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemult.cpp, line 160] 
convert_and_send_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 134] 
mime_LineBuffer [d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 
256] 
MimeObject_parse_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimeobj.cpp, line 256] 
MimeMessage_parse_line 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemsg.cpp, line 214] 
convert_and_send_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 134] 
mime_LineBuffer [d:\builds\seamonkey\mozilla\mailnews\mime\src\mimebuf.cpp, line 
256] 
MimeObject_parse_buffer 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimeobj.cpp, line 256] 
MimeMessage_parse_line 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\mimemsg.cpp, line 131] 
nsInputStreamTee::Read 
[d:\builds\seamonkey\mozilla\xpcom\io\nsInputStreamTee.cpp, line 123] 
nsStreamConverter::OnDataAvailable 
[d:\builds\seamonkey\mozilla\mailnews\mime\src\nsStreamConverter.cpp, line 890] 
nsDocumentOpenInfo::OnDataAvailable 
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 238] 
nsStreamListenerTee::OnDataAvailable 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerTee.cpp, line 57] 
nsOnDataAvailableEvent0::HandleEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line 
416] 
nsStreamListenerEvent0::HandlePLEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line 
107] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 589] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 522] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 
1070] 
nsAppShellService::Run 
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 418] 
Netscp6.exe + 0x16b0 (0x004016b0) 
Netscp6.exe + 0x11b8 (0x004011b8) 
Netscp6.exe + 0x2d84 (0x00402d84) 
KERNEL32.DLL + 0x7903 (0x77e87903) 

Other than that, here are a few comments I found from users that crashed with 
the same stack trace:

- With build 2001051710, reproducible in this build. read mail, sort in 
tree/thread view, click on 2nd message in the thread -> crashes
- With build 2001051922, reading email with URL attachment
- With build 2001052206, moving email message to subfolder

I tried to reproduce with all of these steps, but wasn't able to with today's 
build 2001052304 (that is the Build ID it shows in the title bar of the window, 
but I am actually using the build from the 2001052313 dir on sweetlou).

Comment 5

[lchiang]

may be a particular message causing this problem?

Jay - can you get a report for this stack track showing the user comments and
the email addresses?  This way, we can easily contact the users for more info to
reproduce.

Esther - perhaps this has to do with reading a signed message.  Can you check?

Comment 6

[esther]

I've opened messages with a signature while testing bug 71361 using 5-22 build 
on all 3 platforms.  No crashes, so it isn't simply a signed message.  More 
investigation needed.  

Comment 7

[(not reading, please use [e-mail] instead)]

if it is a signed message, it might be this:

if you installed over an old build, you'd have the signed stub dll in your
components directory.

it has been removed from the product.  there was a crasher bug about this a
while back (stephend logged it?) and it got marked invalid (or worksforme).  the
solution was to remove the old build and install fress, or find and remove the
offending .dll

it might be very easy to reproduce this.  install 0.8, upgrade to a recent
nightly, view a signed message.

a lot of users will run into this.

dbragg, does the installer provide a way to "remove" components?

Comment 8

[chris hofmann]

this bug seems to be behind many of crashes seen by 
[e-mail],[e-mail],[e-mail],[e-mail],[e-mail]
[e-mail], and [e-mail]

http://cyclone/reports/searchstacksignature.cfm?stacksig=nsStringBundleService

seth,  does the definition of "old build" include 6.0/6.01?

if so the number of large and small problems related to installing over
previous release seem to be piling up and we might want to consider
blocking installation over previous major milestones and product releases
just to be safe...

Comment 9

[(not reading, please use [e-mail] instead)]

yes, the signed.dll shipped with 6.0, 6.01.

it was removed on 5/4/2001 (see bug #75767)

so any mozilla or ns build before that would have it (except for really early
builds, like M3) and anything after that built from the trunk would not have it.

tomorrow I can get a pre 5/4 build a trunk build and see if that reproduces the
problem.

I'm eager to hear from dbragg if the installer provides a way to "remove" files
if they exist on installation.  it seems like this is a generic problem that
installer would have already addressed.

cc dveditz, he'd know.

Comment 10

[scottputterman]

Sean Su was just talking to mscott and me today about making the installer 
remove signed.dll during install. Would that take care of this problem?

Comment 11

[Sean Su]

Removing obsolete files when going from (windows) 6.0->6.01->latest builds is 
bug 81601, but PDT does not want to delete any thing more than the problematic 
files.  I'm going to check the fix for bug 81601 in right now.  If we do indeed 
need to have:
  .../components/signed.dll

removed, please update bug 81601 to indicate so due to this bug.  I'll need to 
bring this up with PDT again.

Comment 12

[Cathleen]

I remember this crash.  I actually put in a note in talkback.  The offending 
email was sent by JJ regarding tree status on 5/18 at 1:28pm, and it was a 
signed email.

Comment 13

[scottputterman]

Esther could you try going from 6.0 to a current build and do this installing in
the same directory and see if it makes the crash occur?

Given that the stack trace is going through a .dll that we don't support
anymore, I'm going to update 81601 and ask for signed.dll to be removed.

Comment 14

[dbragg]

Seth, I believe you got your answer from Sean right?  Let me know if you need
any other information.

Comment 15

[esther]

Running the test scott asked for on 5-24, will update bug with results

Comment 16

[esther]

I had 6.01rtm on my system.  I opened it and view all of jj's messages from 5-18 
through 5-22, no crash.  I then installed the 2001-05-23-13 build over the 
6.01rtm build and then launched my profile again.  I read jj's messages again, 
no crash.   Am I missing some steps.  Should the messages have been in an unread 
state when opening them again.  Let me know what else I should do to try to 
reproduce

Comment 17

[esther]

I looked in the components directory where I installed the 5/22 build over the 
6.01 build and the signed.dll is there.  It's dated 01/31/2001.

Comment 18

[Cathleen]

I can see the crash with daily build id 2001052020.  I will install today's 
build and try it out to see if I can see the crash still.

Comment 19

[Cathleen]

I installed today's build (id 2001052404) on top of my old build, and I can 
still see the crash.  Doesn't matter if the message is read or not.  :-)

Comment 20

[Cathleen]

deleting signed.dll from components directory fixes the crash for me.  I put the 
dll back and I can see the crash again.

I'd say lets remove that signed.dll

Comment 21

[scottputterman]

agreed. marking dependency on 81601 and reassigning to ssu.

Comment 22

[(not reading, please use [e-mail] instead)]

marking all, we need to remove the appropriate dll from all 3 platforms.

Comment 23

[esther]

Cathleen, can I get a copy of the "bad" signed.dll, so I can verify this bug 
when fixed.  As you can see from my msg above I do not have a signed.dll that 
causes a crash.  If yours causes my app to crash then I would feel better 
verifying that it's the dll and not a combinations of things.  Thanks

Comment 24

[Sean Su]

adding Samir to the CC: list.

Comment 25

[Cathleen]

I sent a copy of signed.dll to esther already. :-)

Comment 26

[esther]

I tested with Cathleen's copy of signed.dll and I crashed reading JJ's msgs.   
At this time I'm not sure how her .dll became corrupt, because when I installed 
5-22 build over 6.01 and the 5-25 build over 6.0 I do not crash reading JJ's 
messages and the signed.dll are still in the components directories.  Since this 
bug fix will be to remove the signed.dll, I won't spend time trying to reproduce 
the corruption.  Thanks for the .dll Cathleen, now I can verify this bug when 
fixed

Comment 27

[Sean Su]

fix checked in with bug 81601

Comment 28

[esther]

I verified for Windows that the signed.dll in the 6.01 product is removed when
intatlling the 5-31 build over it.  Still waiting to verify linux and mac. 
Should finish that today

Comment 29

[esther]

I verified for linux that the libsigned.so was removed (note: on linux it 
prompts to remove all the files when installing 5-31 build over rtm so all the 
files were removed).  
Mac is installing in a different directory so I still have the Old product and 
new product w/the component directories with the signed.shlb.  Talking to Grace  
about the install process.

Comment 30

[esther]

Mac is OK now.  Verified