Simplify the code for searching places views

REOPENED
Unassigned

Status

()

P3
normal
REOPENED
6 years ago
5 months ago

People

(Reporter: mano, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

There's some mess going on in places.js wrt. search. For resetting the search box, we rely on the fact that the places tree binding doesn't update the "place" value when tree.load is called directly, so we do something like
  tree.place = tree.place;

Apart the fact that it is quite an ugly hack, there are two problems here:
1. Because of this we cannot optimize the tree setter to avoid reloading everything if the "place" value hasn't changed.
2. The new downloads view doesn't use places search for searching downloads,
   so I had to hack its "place" setter to clear the current search term.

I think we should just introduce a "search" method in the pseudo view interface, that takes care of this.

Updated

3 years ago
Assignee: asaf → nobody

Comment 1

5 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → INACTIVE

Updated

5 months ago
Status: RESOLVED → REOPENED
Priority: -- → P3
Resolution: INACTIVE → ---
You need to log in before you can comment on or make changes to this bug.