Closed Bug 822287 Opened 7 years ago Closed 7 years ago

Intermittent devtools/profiler/test/browser_profiler_run.js | First percentage is 100% - Got , expected 100.0%

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86
Windows XP
defect
Not set

Tracking

(firefox20 affected)

RESOLVED FIXED
Tracking Status
firefox20 --- affected

People

(Reporter: emorley, Assigned: anton)

References

Details

(Keywords: intermittent-failure, Whiteboard: [profiler])

Attachments

(1 file)

Rev3 WINNT 5.1 mozilla-inbound pgo test mochitest-browser-chrome on 2012-12-15 21:18:27 PST for push 2c2f92101a69

slave: talos-r3-xp-031

https://tbpl.mozilla.org/php/getParsedLog.php?id=17988802&tree=Mozilla-Inbound

{
TEST-START | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js
MOZ_EVENT_TRACE sample 1355636005968 89
MOZ_EVENT_TRACE sample 1355636006015 84
TEST-INFO | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Console message: [JavaScript Warning: "XUL box for h1 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/profiler.xul" line: 0}]
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Profiler panel exists
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Active profile exists
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Start button exists
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Stop button exists
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Profiler is running
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | Profiler is idle
MOZ_EVENT_TRACE sample 1355636006875 456
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | We have some items displayed
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js | First percentage is 100% - Got , expected 100.0%
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 474
    JS frame :: chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_run.js :: assertSample :: line 85
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
}
This is probably the same underlying problem as bug 810185
Whiteboard: [profiler]
Component: Developer Tools → Developer Tools: Profiler
Anton, please may you take a look at this top orange? :-)
Flags: needinfo?(anton)
Failure rate too high; disabled on Windows pending the needinfo:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58140f9d0c47
Whiteboard: [profiler] → [profiler][test disabled on Windows][leave open]
This looks like the same issue as bug 822041 which we're still investigating.
Flags: needinfo?(anton)
Please can you find an owner for this intermittent-failure - the current overall tree intermittent failure rate is spiralling out of control & most bugs are unowned (see dev.platform thread).
Flags: needinfo?(vporof)
(In reply to Ed Morley [:edmorley UTC+0] from comment #198)
> Please can you find an owner for this intermittent-failure - the current
> overall tree intermittent failure rate is spiralling out of control & most
> bugs are unowned (see dev.platform thread).

We believe that this bug is related to bug 822041 which is owned by Steve.
(In reply to Ed Morley (Away until 13th March) [:edmorley UTC+0] from comment #198)

I'm not sure I can be of much help here, sorry!
Flags: needinfo?(vporof)
Assignee: nobody → anton
Actually, I just looked at it and it's not related to the intermittent profiler crash. In this case, profiler finishes the job but doesn't have any samples. This patch modifies the test case to wait for 100 ms before stopping the profiler. This should be enough for the profiler to collect a bunch of samples.
Attachment #726412 - Flags: review?(past)
Comment on attachment 726412 [details] [diff] [review]
Add a 100 timeout before stopping the profiler (only in tests)

Review of attachment 726412 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #726412 - Flags: review?(past) → review+
Anton, don't forget to revert the cset in comment 139 when landing this.
https://hg.mozilla.org/integration/fx-team/rev/d0573cd334ec

Fingers crossed.
Status: NEW → ASSIGNED
Last failure 18 days ago, closing.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [profiler][test disabled on Windows][leave open] → [profiler][test disabled on Windows]
Whiteboard: [profiler][test disabled on Windows] → [profiler]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.