Closed
Bug 822291
Opened 12 years ago
Closed 12 years ago
[Status Bar] AM/PM is incorrectly implemented
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: padamczyk, Assigned: sjochimek)
Details
(Whiteboard: visual design, incorrect implementation, UX-P2, uxbranch)
Attachments
(3 files)
140.59 KB,
image/png
|
Details | |
213 bytes,
text/html
|
Details | |
216 bytes,
text/html
|
kaze
:
review+
vingtetun
:
approval-gaia-v1+
|
Details |
This has been incorrectly implemented as it hasn't had visual design consultation.
+ Please make AM/PM 10px or 1rem
+ No gap between clock and AM/PM
Assignee | ||
Comment 1•12 years ago
|
||
Question: The AM/PM is local specific ? Cause there is no specific tag for this information ?
I think of including a tag in the local value, Kaze is this a good idea ?
Flags: needinfo?(kaze)
Comment 2•12 years ago
|
||
s/local/locale/g
(In reply to Sam Joch:samjoch from comment #1)
> Question: The AM/PM is local specific ?
Yes, it’s locale-specific.
> I think of including a tag in the local value, Kaze is this a good idea ?
It doesn’t sound like one, but I’m not sure what you mean.
Very similar bugs have been addressed by retrieving the (potential) am/pm string with a regexp, I’m OK with this approach (though not ideal, of course).
Flags: needinfo?(kaze)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #699148 -
Flags: review?(kaze)
Attachment #699148 -
Flags: feedback?(padamczyk)
Comment 4•12 years ago
|
||
Sam, would you open a pull request please?
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #699160 -
Flags: review?(kaze)
Assignee | ||
Updated•12 years ago
|
Attachment #699148 -
Flags: review?(kaze)
Comment 7•12 years ago
|
||
Comment on attachment 699160 [details]
PR
r=me, thanks!
Attachment #699160 -
Flags: review?(kaze) → review+
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 9•12 years ago
|
||
Comment on attachment 699160 [details]
PR
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: the time in the status bar could be nicer (only affects en-US)
Testing completed: manual
Risk to taking this patch (and alternatives if risky): low
Sorry, I landed this patch before I realizes it didn’t have the BB+.
Attachment #699160 -
Flags: approval-gaia-master?(21)
Comment 10•12 years ago
|
||
Comment on attachment 699160 [details]
PR
Post mortem a+.
Attachment #699160 -
Flags: approval-gaia-master?(21) → approval-gaia-master+
Reporter | ||
Updated•12 years ago
|
Attachment #699148 -
Flags: feedback?(padamczyk)
You need to log in
before you can comment on or make changes to this bug.
Description
•